Skip to content

Commit f69025d

Browse files
krzkgclement
authored andcommitted
arm64: dts: marvell: cn9130-crb: drop wrong unit-addresses
Top-level nodes, not being on MMIO bus, do not have "reg" properties and should not have unit addresses. Correct their name as well to match "Generic node names" recommendation from Devicetree specification. This also fixes dtc W=1 warnings: cn9130-crb.dtsi:29.35-37.4: Warning (unit_address_vs_reg): /ap0_mmc_vccq@0: node has a unit name, but no reg or ranges property cn9130-crb.dtsi:39.38-46.4: Warning (unit_address_vs_reg): /cp0_usb3_vbus@1: node has a unit name, but no reg or ranges property cn9130-crb.dtsi:57.33-65.4: Warning (unit_address_vs_reg): /cp0_sd_vccq@0: node has a unit name, but no reg or ranges property cn9130-crb.dtsi:67.31-75.4: Warning (unit_address_vs_reg): /cp0_sd_vcc@0: node has a unit name, but no reg or ranges property Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
1 parent 0f78d6d commit f69025d

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

arch/arm64/boot/dts/marvell/cn9130-crb.dtsi

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
reg = <0x0 0x0 0x0 0x80000000>;
2727
};
2828

29-
ap0_reg_mmc_vccq: ap0_mmc_vccq@0 {
29+
ap0_reg_mmc_vccq: regulator-1 {
3030
compatible = "regulator-gpio";
3131
regulator-name = "ap0_mmc_vccq";
3232
regulator-min-microvolt = <1800000>;
@@ -36,7 +36,7 @@
3636
3300000 0x0>;
3737
};
3838

39-
cp0_reg_usb3_vbus1: cp0_usb3_vbus@1 {
39+
cp0_reg_usb3_vbus1: regulator-2 {
4040
compatible = "regulator-fixed";
4141
regulator-name = "cp0-xhci1-vbus";
4242
regulator-min-microvolt = <5000000>;
@@ -45,16 +45,16 @@
4545
gpio = <&expander0 8 GPIO_ACTIVE_HIGH>;
4646
};
4747

48-
cp0_usb3_0_phy0: cp0_usb3_phy0 {
48+
cp0_usb3_0_phy0: usb-phy-1 {
4949
compatible = "usb-nop-xceiv";
5050
};
5151

52-
cp0_usb3_0_phy1: cp0_usb3_phy1 {
52+
cp0_usb3_0_phy1: usb-phy-2 {
5353
compatible = "usb-nop-xceiv";
5454
vcc-supply = <&cp0_reg_usb3_vbus1>;
5555
};
5656

57-
cp0_reg_sd_vccq: cp0_sd_vccq@0 {
57+
cp0_reg_sd_vccq: regulator-3 {
5858
compatible = "regulator-gpio";
5959
regulator-name = "cp0_sd_vccq";
6060
regulator-min-microvolt = <1800000>;
@@ -64,7 +64,7 @@
6464
3300000 0x0>;
6565
};
6666

67-
cp0_reg_sd_vcc: cp0_sd_vcc@0 {
67+
cp0_reg_sd_vcc: regulator-4 {
6868
compatible = "regulator-fixed";
6969
regulator-name = "cp0_sd_vcc";
7070
regulator-min-microvolt = <3300000>;

0 commit comments

Comments
 (0)