Skip to content

Commit f6bc712

Browse files
Sebastian Andrzej SiewiorThomas Gleixner
authored andcommitted
platform/x86: int0002: Remove IRQF_ONESHOT from request_irq()
Passing IRQF_ONESHOT ensures that the interrupt source is masked until the secondary (threaded) handler is done. If only a primary handler is used then the flag makes no sense because the interrupt cannot fire (again) while its handler is running. The flag also prevents force-threading of the primary handler and the irq-core will warn about this. The flag was added to match the flag on the shared handler which uses a threaded handler and therefore IRQF_ONESHOT. This is no longer needed because devm_request_irq() now passes IRQF_COND_ONESHOT for this case. Revert adding IRQF_ONESHOT to irqflags. Fixes: 8f81237 ("platform/x86: intel: int0002_vgpio: Pass IRQF_ONESHOT to request_irq()") Reported-by: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com> Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://patch.msgid.link/20260128095540.863589-3-bigeasy@linutronix.de Closes: https://lore.kernel.org/all/555f1c56-0f74-41bf-8bd2-6217e0aab0c6@intel.com
1 parent 943b052 commit f6bc712

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/platform/x86/intel/int0002_vgpio.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ static int int0002_probe(struct platform_device *pdev)
206206
* FIXME: augment this if we managed to pull handling of shared
207207
* IRQs into gpiolib.
208208
*/
209-
ret = devm_request_irq(dev, irq, int0002_irq,
210-
IRQF_ONESHOT | IRQF_SHARED, "INT0002", chip);
209+
ret = devm_request_irq(dev, irq, int0002_irq, IRQF_SHARED, "INT0002",
210+
chip);
211211
if (ret) {
212212
dev_err(dev, "Error requesting IRQ %d: %d\n", irq, ret);
213213
return ret;

0 commit comments

Comments
 (0)