Skip to content

Commit f6d7545

Browse files
rddunlaplumag
authored andcommitted
drm/msm/dpu: dpu_hw_intf.h: fix all kernel-doc warnings
Correct or add kernel-doc comments to eliminate all warnings: Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h:76 duplicate section name 'Return' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h:112 Incorrect use of kernel-doc format: * Disable autorefresh if enabled Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h:118 struct member 'setup_timing_gen' not described in 'dpu_hw_intf_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h:118 struct member 'setup_prg_fetch' not described in 'dpu_hw_intf_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h:118 struct member 'enable_timing' not described in 'dpu_hw_intf_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h:118 struct member 'get_status' not described in 'dpu_hw_intf_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h:118 struct member 'get_line_count' not described in 'dpu_hw_intf_ops' Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h:118 struct member 'disable_autorefresh' not described in 'dpu_hw_intf_ops' dpu_hw_intf.h:119: warning: Excess struct member 'get_vsync_info' description in 'dpu_hw_intf_ops' dpu_hw_intf.h:119: warning: Excess struct member 'setup_autorefresh' description in 'dpu_hw_intf_ops' dpu_hw_intf.h:119: warning: Excess struct member 'get_autorefresh' description in 'dpu_hw_intf_ops' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Patchwork: https://patchwork.freedesktop.org/patch/695646/ Link: https://lore.kernel.org/r/20251219184638.1813181-9-rdunlap@infradead.org Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
1 parent 399f434 commit f6d7545

1 file changed

Lines changed: 7 additions & 13 deletions

File tree

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ struct dpu_hw_intf_cmd_mode_cfg {
5757
/**
5858
* struct dpu_hw_intf_ops : Interface to the interface Hw driver functions
5959
* Assumption is these functions will be called after clocks are enabled
60-
* @ setup_timing_gen : programs the timing engine
61-
* @ setup_prog_fetch : enables/disables the programmable fetch logic
62-
* @ enable_timing: enable/disable timing engine
63-
* @ get_status: returns if timing engine is enabled or not
64-
* @ get_line_count: reads current vertical line counter
60+
* @setup_timing_gen : programs the timing engine
61+
* @setup_prg_fetch : enables/disables the programmable fetch logic
62+
* @enable_timing: enable/disable timing engine
63+
* @get_status: returns if timing engine is enabled or not
64+
* @get_line_count: reads current vertical line counter
6565
* @bind_pingpong_blk: enable/disable the connection with pingpong which will
6666
* feed pixels to this interface
6767
* @setup_misr: enable/disable MISR
@@ -70,12 +70,9 @@ struct dpu_hw_intf_cmd_mode_cfg {
7070
* pointer and programs the tear check configuration
7171
* @disable_tearcheck: Disables tearcheck block
7272
* @connect_external_te: Read, modify, write to either set or clear listening to external TE
73-
* Return: 1 if TE was originally connected, 0 if not, or -ERROR
74-
* @get_vsync_info: Provides the programmed and current line_count
75-
* @setup_autorefresh: Configure and enable the autorefresh config
76-
* @get_autorefresh: Retrieve autorefresh config from hardware
77-
* Return: 0 on success, -ETIMEDOUT on timeout
73+
* Returns 1 if TE was originally connected, 0 if not, or -ERROR
7874
* @vsync_sel: Select vsync signal for tear-effect configuration
75+
* @disable_autorefresh: Disable autorefresh if enabled
7976
* @program_intf_cmd_cfg: Program the DPU to interface datapath for command mode
8077
*/
8178
struct dpu_hw_intf_ops {
@@ -109,9 +106,6 @@ struct dpu_hw_intf_ops {
109106

110107
void (*vsync_sel)(struct dpu_hw_intf *intf, enum dpu_vsync_source vsync_source);
111108

112-
/**
113-
* Disable autorefresh if enabled
114-
*/
115109
void (*disable_autorefresh)(struct dpu_hw_intf *intf, uint32_t encoder_id, u16 vdisplay);
116110

117111
void (*program_intf_cmd_cfg)(struct dpu_hw_intf *intf,

0 commit comments

Comments
 (0)