Skip to content

Commit f6e7ac4

Browse files
flynnjiangjwrdegoede
authored andcommitted
platform/x86/amd: pmc: Fix memory leak in amd_pmc_stb_debugfs_open_v2()
Function amd_pmc_stb_debugfs_open_v2() may be called when the STB debug mechanism enabled. When amd_pmc_send_cmd() fails, the 'buf' needs to be released. Signed-off-by: Feng Jiang <jiangfeng@kylinos.cn> Link: https://lore.kernel.org/r/20230412093734.1126410-1-jiangfeng@kylinos.cn Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 82c3a0b commit f6e7ac4

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

  • drivers/platform/x86/amd

drivers/platform/x86/amd/pmc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ static int amd_pmc_stb_debugfs_open_v2(struct inode *inode, struct file *filp)
265265
dev->msg_port = 0;
266266
if (ret) {
267267
dev_err(dev->dev, "error: S2D_NUM_SAMPLES not supported : %d\n", ret);
268+
kfree(buf);
268269
return ret;
269270
}
270271

0 commit comments

Comments
 (0)