Skip to content

Commit f70b004

Browse files
ramosian-glidertorvalds
authored andcommitted
kasan: slab: always reset the tag in get_freepointer_safe()
With CONFIG_DEBUG_PAGEALLOC enabled, the kernel should also untag the object pointer, as done in get_freepointer(). Failing to do so reportedly leads to SLUB freelist corruptions that manifest as boot-time crashes. Link: https://lkml.kernel.org/r/20210514072228.534418-1-glider@google.com Signed-off-by: Alexander Potapenko <glider@google.com> Cc: Marco Elver <elver@google.com> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Andrey Konovalov <andreyknvl@gmail.com> Cc: Elliot Berman <eberman@codeaurora.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 4d1cd3b commit f70b004

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

mm/slub.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,7 @@ static inline void *get_freepointer_safe(struct kmem_cache *s, void *object)
301301
if (!debug_pagealloc_enabled_static())
302302
return get_freepointer(s, object);
303303

304+
object = kasan_reset_tag(object);
304305
freepointer_addr = (unsigned long)object + s->offset;
305306
copy_from_kernel_nofault(&p, (void **)freepointer_addr, sizeof(p));
306307
return freelist_ptr(s, p, freepointer_addr);

0 commit comments

Comments
 (0)