media: sun6i-isp: proc: Error out on invalid port to fix warning

paulkocialkowski · mchehab · commit f72af7709478 · 2022-12-14T18:12:31.000Z
The enabled variable is only set for a valid port and used later, which triggers an uninitialized use smatch warning. Explicitly error out in that case to fix the warning. Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Fixes: e3185e1 ("media: staging: media: Add support for the Allwinner A31 ISP") Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c
@@ -416,7 +416,7 @@ static int sun6i_isp_proc_notifier_bound(struct v4l2_async_notifier *notifier,
 		enabled = !proc->source_csi0.expected;
 		break;
 	default:
-		break;
+		return -EINVAL;
 	}
 
 	source->subdev = remote_subdev;

Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,7 @@ static int sun6i_isp_proc_notifier_bound(struct v4l2_async_notifier *notifier,`
`416`	`416`	`enabled = !proc->source_csi0.expected;`
`417`	`417`	`break;`
`418`	`418`	`default:`
`419`		`- break;`
	`419`	`+ return -EINVAL;`
`420`	`420`	`}`
`421`	`421`
`422`	`422`	`source->subdev = remote_subdev;`