Skip to content

Commit f78fb94

Browse files
committed
clk: sprd: div: convert from divider_round_rate() to divider_determine_rate()
The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate = divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: deb4740 ("clk: sprd: div: convert from round_rate() to determine_rate()") Signed-off-by: Brian Masney <bmasney@redhat.com>
1 parent 77b04dc commit f78fb94

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

drivers/clk/sprd/div.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,7 @@ static int sprd_div_determine_rate(struct clk_hw *hw,
1414
{
1515
struct sprd_div *cd = hw_to_sprd_div(hw);
1616

17-
req->rate = divider_round_rate(&cd->common.hw, req->rate,
18-
&req->best_parent_rate,
19-
NULL, cd->div.width, 0);
20-
21-
return 0;
17+
return divider_determine_rate(&cd->common.hw, req, NULL, cd->div.width, 0);
2218
}
2319

2420
unsigned long sprd_div_helper_recalc_rate(struct sprd_clk_common *common,

0 commit comments

Comments
 (0)