Skip to content

Commit f7e35e4

Browse files
cometzerogregkh
authored andcommitted
tty: serial: samsung_tty: set dma burst_size to 1
The src_maxburst and dst_maxburst have been changed to 1 but the settings of the UCON register aren't changed yet. They should be changed as well according to the dmaengine slave config. Fixes: aa2f80e ("serial: samsung: fix maxburst parameter for DMA transactions") Cc: stable <stable@kernel.org> Cc: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Chanho Park <chanho61.park@samsung.com> Link: https://lore.kernel.org/r/20220627065113.139520-1-chanho61.park@samsung.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent cd16044 commit f7e35e4

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/tty/serial/samsung_tty.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -377,8 +377,7 @@ static void enable_tx_dma(struct s3c24xx_uart_port *ourport)
377377
/* Enable tx dma mode */
378378
ucon = rd_regl(port, S3C2410_UCON);
379379
ucon &= ~(S3C64XX_UCON_TXBURST_MASK | S3C64XX_UCON_TXMODE_MASK);
380-
ucon |= (dma_get_cache_alignment() >= 16) ?
381-
S3C64XX_UCON_TXBURST_16 : S3C64XX_UCON_TXBURST_1;
380+
ucon |= S3C64XX_UCON_TXBURST_1;
382381
ucon |= S3C64XX_UCON_TXMODE_DMA;
383382
wr_regl(port, S3C2410_UCON, ucon);
384383

@@ -674,7 +673,7 @@ static void enable_rx_dma(struct s3c24xx_uart_port *ourport)
674673
S3C64XX_UCON_DMASUS_EN |
675674
S3C64XX_UCON_TIMEOUT_EN |
676675
S3C64XX_UCON_RXMODE_MASK);
677-
ucon |= S3C64XX_UCON_RXBURST_16 |
676+
ucon |= S3C64XX_UCON_RXBURST_1 |
678677
0xf << S3C64XX_UCON_TIMEOUT_SHIFT |
679678
S3C64XX_UCON_EMPTYINT_EN |
680679
S3C64XX_UCON_TIMEOUT_EN |

0 commit comments

Comments
 (0)