Skip to content

Commit f804360

Browse files
Konrad Dybcioandersson
authored andcommitted
clk: qcom: smd: Add missing RPM clocks for msm8992/4
XO and MSS_CFG were omitted when first adding the clocks for these SoCs. Add them, and while at it, move the XO clock to the top of the definition list, as ideally everyone should start using it sooner or later.. Fixes: b429784 ("clk: qcom: smd: Add support for MSM8992/4 rpm clocks") Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20220226214126.21209-2-konrad.dybcio@somainline.org
1 parent 5b2fa28 commit f804360

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

drivers/clk/qcom/clk-smd-rpm.c

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -413,6 +413,7 @@ static const struct clk_ops clk_smd_rpm_branch_ops = {
413413
.recalc_rate = clk_smd_rpm_recalc_rate,
414414
};
415415

416+
DEFINE_CLK_SMD_RPM_BRANCH(sdm660, bi_tcxo, bi_tcxo_a, QCOM_SMD_RPM_MISC_CLK, 0, 19200000);
416417
DEFINE_CLK_SMD_RPM(msm8916, pcnoc_clk, pcnoc_a_clk, QCOM_SMD_RPM_BUS_CLK, 0);
417418
DEFINE_CLK_SMD_RPM(msm8916, snoc_clk, snoc_a_clk, QCOM_SMD_RPM_BUS_CLK, 1);
418419
DEFINE_CLK_SMD_RPM(msm8916, bimc_clk, bimc_a_clk, QCOM_SMD_RPM_MEM_CLK, 0);
@@ -604,7 +605,11 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER(msm8992, ln_bb_clk, ln_bb_a_clk, 8, 19200000);
604605
DEFINE_CLK_SMD_RPM(msm8992, ce1_clk, ce1_a_clk, QCOM_SMD_RPM_CE_CLK, 0);
605606
DEFINE_CLK_SMD_RPM(msm8992, ce2_clk, ce2_a_clk, QCOM_SMD_RPM_CE_CLK, 1);
606607

608+
DEFINE_CLK_SMD_RPM_BRANCH(msm8992, mss_cfg_ahb_clk, mss_cfg_ahb_a_clk,
609+
QCOM_SMD_RPM_MCFG_CLK, 0, 19200000);
607610
static struct clk_smd_rpm *msm8992_clks[] = {
611+
[RPM_SMD_XO_CLK_SRC] = &sdm660_bi_tcxo,
612+
[RPM_SMD_XO_A_CLK_SRC] = &sdm660_bi_tcxo_a,
608613
[RPM_SMD_PNOC_CLK] = &msm8916_pcnoc_clk,
609614
[RPM_SMD_PNOC_A_CLK] = &msm8916_pcnoc_a_clk,
610615
[RPM_SMD_OCMEMGX_CLK] = &msm8974_ocmemgx_clk,
@@ -637,6 +642,8 @@ static struct clk_smd_rpm *msm8992_clks[] = {
637642
[RPM_SMD_LN_BB_A_CLK] = &msm8992_ln_bb_a_clk,
638643
[RPM_SMD_MMSSNOC_AHB_CLK] = &msm8974_mmssnoc_ahb_clk,
639644
[RPM_SMD_MMSSNOC_AHB_A_CLK] = &msm8974_mmssnoc_ahb_a_clk,
645+
[RPM_SMD_MSS_CFG_AHB_CLK] = &msm8992_mss_cfg_ahb_clk,
646+
[RPM_SMD_MSS_CFG_AHB_A_CLK] = &msm8992_mss_cfg_ahb_a_clk,
640647
[RPM_SMD_QDSS_CLK] = &msm8916_qdss_clk,
641648
[RPM_SMD_QDSS_A_CLK] = &msm8916_qdss_a_clk,
642649
[RPM_SMD_RF_CLK1] = &msm8916_rf_clk1,
@@ -661,6 +668,8 @@ static const struct rpm_smd_clk_desc rpm_clk_msm8992 = {
661668
DEFINE_CLK_SMD_RPM(msm8994, ce3_clk, ce3_a_clk, QCOM_SMD_RPM_CE_CLK, 2);
662669

663670
static struct clk_smd_rpm *msm8994_clks[] = {
671+
[RPM_SMD_XO_CLK_SRC] = &sdm660_bi_tcxo,
672+
[RPM_SMD_XO_A_CLK_SRC] = &sdm660_bi_tcxo_a,
664673
[RPM_SMD_PNOC_CLK] = &msm8916_pcnoc_clk,
665674
[RPM_SMD_PNOC_A_CLK] = &msm8916_pcnoc_a_clk,
666675
[RPM_SMD_OCMEMGX_CLK] = &msm8974_ocmemgx_clk,
@@ -693,6 +702,8 @@ static struct clk_smd_rpm *msm8994_clks[] = {
693702
[RPM_SMD_LN_BB_A_CLK] = &msm8992_ln_bb_a_clk,
694703
[RPM_SMD_MMSSNOC_AHB_CLK] = &msm8974_mmssnoc_ahb_clk,
695704
[RPM_SMD_MMSSNOC_AHB_A_CLK] = &msm8974_mmssnoc_ahb_a_clk,
705+
[RPM_SMD_MSS_CFG_AHB_CLK] = &msm8992_mss_cfg_ahb_clk,
706+
[RPM_SMD_MSS_CFG_AHB_A_CLK] = &msm8992_mss_cfg_ahb_a_clk,
696707
[RPM_SMD_QDSS_CLK] = &msm8916_qdss_clk,
697708
[RPM_SMD_QDSS_A_CLK] = &msm8916_qdss_a_clk,
698709
[RPM_SMD_RF_CLK1] = &msm8916_rf_clk1,
@@ -857,8 +868,6 @@ static const struct rpm_smd_clk_desc rpm_clk_msm8998 = {
857868
.num_clks = ARRAY_SIZE(msm8998_clks),
858869
};
859870

860-
DEFINE_CLK_SMD_RPM_BRANCH(sdm660, bi_tcxo, bi_tcxo_a, QCOM_SMD_RPM_MISC_CLK, 0,
861-
19200000);
862871
DEFINE_CLK_SMD_RPM_XO_BUFFER(sdm660, ln_bb_clk3, ln_bb_clk3_a, 3, 19200000);
863872
DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(sdm660, ln_bb_clk3_pin, ln_bb_clk3_pin_a, 3, 19200000);
864873

include/linux/soc/qcom/smd-rpm.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ struct qcom_smd_rpm;
4040
#define QCOM_SMD_RPM_AGGR_CLK 0x72676761
4141
#define QCOM_SMD_RPM_HWKM_CLK 0x6d6b7768
4242
#define QCOM_SMD_RPM_PKA_CLK 0x616b70
43+
#define QCOM_SMD_RPM_MCFG_CLK 0x6766636d
4344

4445
int qcom_rpm_smd_write(struct qcom_smd_rpm *rpm,
4546
int state,

0 commit comments

Comments
 (0)