Skip to content

Commit f810b81

Browse files
Niklas Casseldamien-lemoal
authored andcommitted
ata: sata_sx4: drop already completed TODO
The TODO claims that the pdc_20621_ops should set the .inherits function pointer to &ata_base_port_ops after it has been converted to use the new EH. However, the driver was converted to use the new EH a long time ago, in commit 67651ee ("[libata] sata_sx4: convert to new exception handling methods"), which also did set .inherits function pointer to &ata_sff_port_ops (and ata_sff_port_ops itself has .inherits set to &ata_base_port_ops). Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Reviewed-by: Jason Yan <yanaijie@huawei.com> Reviewed-by: John Garry <john.g.garry@oracle.com> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
1 parent 5415281 commit f810b81

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/ata/sata_sx4.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,6 @@ static const struct scsi_host_template pdc_sata_sht = {
232232
.dma_boundary = ATA_DMA_BOUNDARY,
233233
};
234234

235-
/* TODO: inherit from base port_ops after converting to new EH */
236235
static struct ata_port_operations pdc_20621_ops = {
237236
.inherits = &ata_sff_port_ops,
238237

0 commit comments

Comments
 (0)