RDMA/mana_ib: Fix missing ret value

Konstantin Taranov · jgunthorpe · commit f88320b698ad · 2024-04-23T12:02:44.000-03:00
Set ret to -ENODEV when netdev_master_upper_dev_get_rcu returns NULL. Fixes: 8b184e4 ("RDMA/mana_ib: Enable RoCE on port 1") Link: https://lore.kernel.org/r/1713881751-21621-1-git-send-email-kotaranov@linux.microsoft.com Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c
@@ -87,6 +87,7 @@ static int mana_ib_probe(struct auxiliary_device *adev,
 	upper_ndev = netdev_master_upper_dev_get_rcu(mc->ports[0]);
 	if (!upper_ndev) {
 		rcu_read_unlock();
+		ret = -ENODEV;
 		ibdev_err(&dev->ib_dev, "Failed to get master netdev");
 		goto free_ib_device;
 	}

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,7 @@ static int mana_ib_probe(struct auxiliary_device *adev,`
`87`	`87`	`upper_ndev = netdev_master_upper_dev_get_rcu(mc->ports[0]);`
`88`	`88`	`if (!upper_ndev) {`
`89`	`89`	`rcu_read_unlock();`
	`90`	`+ ret = -ENODEV;`
`90`	`91`	`ibdev_err(&dev->ib_dev, "Failed to get master netdev");`
`91`	`92`	`goto free_ib_device;`
`92`	`93`	`}`