Skip to content

Commit f886b49

Browse files
Tao Zhoualexdeucher
authored andcommitted
drm/amdgpu: implement IRQ_STATE_ENABLE for SDMA v4.4.2
SDMA_CNTL is not set in some cases, driver configures it by itself. v2: simplify code Signed-off-by: Tao Zhou <tao.zhou1@amd.com> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 533eefb commit f886b49

1 file changed

Lines changed: 3 additions & 13 deletions

File tree

drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1602,19 +1602,9 @@ static int sdma_v4_4_2_set_ecc_irq_state(struct amdgpu_device *adev,
16021602
u32 sdma_cntl;
16031603

16041604
sdma_cntl = RREG32_SDMA(type, regSDMA_CNTL);
1605-
switch (state) {
1606-
case AMDGPU_IRQ_STATE_DISABLE:
1607-
sdma_cntl = REG_SET_FIELD(sdma_cntl, SDMA_CNTL,
1608-
DRAM_ECC_INT_ENABLE, 0);
1609-
WREG32_SDMA(type, regSDMA_CNTL, sdma_cntl);
1610-
break;
1611-
/* sdma ecc interrupt is enabled by default
1612-
* driver doesn't need to do anything to
1613-
* enable the interrupt */
1614-
case AMDGPU_IRQ_STATE_ENABLE:
1615-
default:
1616-
break;
1617-
}
1605+
sdma_cntl = REG_SET_FIELD(sdma_cntl, SDMA_CNTL, DRAM_ECC_INT_ENABLE,
1606+
state == AMDGPU_IRQ_STATE_ENABLE ? 1 : 0);
1607+
WREG32_SDMA(type, regSDMA_CNTL, sdma_cntl);
16181608

16191609
return 0;
16201610
}

0 commit comments

Comments
 (0)