Skip to content

Commit f890987

Browse files
wwessnerjic23
authored andcommitted
iio: adc: ad7949: fix wrong ADC result due to incorrect bit mask
Fixes a wrong bit mask used for the ADC's result, which was caused by an improper usage of the GENMASK() macro. The bits higher than ADC's resolution are undefined and if not masked out correctly, a wrong result can be given. The GENMASK() macro indexing is zero based, so the mask has to go from [resolution - 1 , 0]. Fixes: 7f40e06 ("iio:adc:ad7949: Add AD7949 ADC driver family") Signed-off-by: Wilfried Wessner <wilfried.wessner@gmail.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by: Charles-Antoine Couret <charles-antoine.couret@essensium.com> Cc: <Stable@vger.kernel.org> Link: https://lore.kernel.org/r/20210208142705.GA51260@ubuntu Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent d68c592 commit f890987

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/iio/adc/ad7949.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ static int ad7949_spi_read_channel(struct ad7949_adc_chip *ad7949_adc, int *val,
9191
int ret;
9292
int i;
9393
int bits_per_word = ad7949_adc->resolution;
94-
int mask = GENMASK(ad7949_adc->resolution, 0);
94+
int mask = GENMASK(ad7949_adc->resolution - 1, 0);
9595
struct spi_message msg;
9696
struct spi_transfer tx[] = {
9797
{

0 commit comments

Comments
 (0)