Skip to content

Commit f9346f0

Browse files
vladimirolteandavem330
authored andcommitted
net: dsa: tag_sja1105: don't rely on skb_mac_header() in TX paths
skb_mac_header() will no longer be available in the TX path when reverting commit 6d1ccff ("net: reset mac header in dev_start_xmit()"). As preparation for that, let's use skb_vlan_eth_hdr() to get to the VLAN header instead, which assumes it's located at skb->data (assumption which holds true here). Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 499b249 commit f9346f0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/dsa/tag_sja1105.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ static struct sk_buff *sja1105_pvid_tag_control_pkt(struct dsa_port *dp,
256256
return NULL;
257257
}
258258

259-
hdr = (struct vlan_ethhdr *)skb_mac_header(skb);
259+
hdr = skb_vlan_eth_hdr(skb);
260260

261261
/* If skb is already VLAN-tagged, leave that VLAN ID in place */
262262
if (hdr->h_vlan_proto == xmit_tpid)

0 commit comments

Comments
 (0)