Skip to content

Commit f941714

Browse files
claudiubezneaLinus Walleij
authored andcommitted
pinctrl: mcp23s08: check return value of devm_kasprintf()
devm_kasprintf() returns a pointer to dynamically allocated memory. Pointer could be NULL in case allocation fails. Check pointer validity. Identified with coccinelle (kmerr.cocci script). Fixes: 0f04a81 ("pinctrl: mcp23s08: Split to three parts: core, I²C, SPI") Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230621100409.1608395-1-claudiu.beznea@microchip.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 6387e0a commit f941714

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

drivers/pinctrl/pinctrl-mcp23s08_spi.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,18 +91,28 @@ static int mcp23s08_spi_regmap_init(struct mcp23s08 *mcp, struct device *dev,
9191
mcp->reg_shift = 0;
9292
mcp->chip.ngpio = 8;
9393
mcp->chip.label = devm_kasprintf(dev, GFP_KERNEL, "mcp23s08.%d", addr);
94+
if (!mcp->chip.label)
95+
return -ENOMEM;
9496

9597
config = &mcp23x08_regmap;
9698
name = devm_kasprintf(dev, GFP_KERNEL, "%d", addr);
99+
if (!name)
100+
return -ENOMEM;
101+
97102
break;
98103

99104
case MCP_TYPE_S17:
100105
mcp->reg_shift = 1;
101106
mcp->chip.ngpio = 16;
102107
mcp->chip.label = devm_kasprintf(dev, GFP_KERNEL, "mcp23s17.%d", addr);
108+
if (!mcp->chip.label)
109+
return -ENOMEM;
103110

104111
config = &mcp23x17_regmap;
105112
name = devm_kasprintf(dev, GFP_KERNEL, "%d", addr);
113+
if (!name)
114+
return -ENOMEM;
115+
106116
break;
107117

108118
case MCP_TYPE_S18:

0 commit comments

Comments
 (0)