Skip to content

Commit f95f3bc

Browse files
jhovoldsvenpeter42
authored andcommitted
soc: apple: sart: drop device reference after lookup
Holding a reference to a device does not prevent its driver data from going away so there is no point in keeping the reference after looking up the sart device. Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Neal Gompa <neal@gompa.dev> Signed-off-by: Sven Peter <sven@kernel.org>
1 parent f401671 commit f95f3bc

1 file changed

Lines changed: 2 additions & 11 deletions

File tree

drivers/soc/apple/sart.c

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -214,17 +214,11 @@ static int apple_sart_probe(struct platform_device *pdev)
214214
return 0;
215215
}
216216

217-
static void apple_sart_put_device(void *dev)
218-
{
219-
put_device(dev);
220-
}
221-
222217
struct apple_sart *devm_apple_sart_get(struct device *dev)
223218
{
224219
struct device_node *sart_node;
225220
struct platform_device *sart_pdev;
226221
struct apple_sart *sart;
227-
int ret;
228222

229223
sart_node = of_parse_phandle(dev->of_node, "apple,sart", 0);
230224
if (!sart_node)
@@ -242,14 +236,11 @@ struct apple_sart *devm_apple_sart_get(struct device *dev)
242236
return ERR_PTR(-EPROBE_DEFER);
243237
}
244238

245-
ret = devm_add_action_or_reset(dev, apple_sart_put_device,
246-
&sart_pdev->dev);
247-
if (ret)
248-
return ERR_PTR(ret);
249-
250239
device_link_add(dev, &sart_pdev->dev,
251240
DL_FLAG_PM_RUNTIME | DL_FLAG_AUTOREMOVE_SUPPLIER);
252241

242+
put_device(&sart_pdev->dev);
243+
253244
return sart;
254245
}
255246
EXPORT_SYMBOL_GPL(devm_apple_sart_get);

0 commit comments

Comments
 (0)