Skip to content

Commit f99cf99

Browse files
Jakub Boehmlunn
authored andcommitted
net: plip: fix break; causing plip to never transmit
Since commit 71ae2cb ("net: plip: Fix fall-through warnings for Clang") plip was not able to send any packets, this patch replaces one unintended break; with fallthrough; which was originally missed by commit 9525d69 ("net: plip: mark expected switch fall-throughs"). I have verified with a real hardware PLIP connection that everything works once again after applying this patch. Fixes: 71ae2cb ("net: plip: Fix fall-through warnings for Clang") Signed-off-by: Jakub Boehm <boehm.jakub@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Message-ID: <20241015-net-plip-tx-fix-v1-1-32d8be1c7e0b@gmail.com> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
1 parent e4dd8bf commit f99cf99

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/plip/plip.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -815,7 +815,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
815815
return HS_TIMEOUT;
816816
}
817817
}
818-
break;
818+
fallthrough;
819819

820820
case PLIP_PK_LENGTH_LSB:
821821
if (plip_send(nibble_timeout, dev,

0 commit comments

Comments
 (0)