Skip to content

Commit fa020a2

Browse files
committed
mm/shmem.c: suppress shift warning
mm/shmem.c:1948 shmem_getpage_gfp() warn: should '(((1) << 12) / 512) << folio_order(folio)' be a 64 bit type? On i386, so an unsigned long is 32-bit, but i_blocks is a 64-bit blkcnt_t. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Jessica Clarke <jrtc27@jrtc27.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent 0710d01 commit fa020a2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

mm/shmem.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1945,7 +1945,7 @@ static int shmem_getpage_gfp(struct inode *inode, pgoff_t index,
19451945

19461946
spin_lock_irq(&info->lock);
19471947
info->alloced += folio_nr_pages(folio);
1948-
inode->i_blocks += BLOCKS_PER_PAGE << folio_order(folio);
1948+
inode->i_blocks += (blkcnt_t)BLOCKS_PER_PAGE << folio_order(folio);
19491949
shmem_recalc_inode(inode);
19501950
spin_unlock_irq(&info->lock);
19511951
alloced = true;

0 commit comments

Comments
 (0)