Skip to content

Commit fa02de9

Browse files
baruchsiachkuba-moo
authored andcommitted
net: stmmac: fix rx budget limit check
The while loop condition verifies 'count < limit'. Neither value change before the 'count >= limit' check. As is this check is dead code. But code inspection reveals a code path that modifies 'count' and then goto 'drain_data' and back to 'read_again'. So there is a need to verify count value sanity after 'read_again'. Move 'read_again' up to fix the count limit check. Fixes: ec22200 ("net: stmmac: Prepare to add Split Header support") Signed-off-by: Baruch Siach <baruch@tkos.co.il> Reviewed-by: Serge Semin <fancer.lancer@gmail.com> Link: https://lore.kernel.org/r/d9486296c3b6b12ab3a0515fcd47d56447a07bfc.1699897370.git.baruch@tkos.co.il Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 4b7b492 commit fa02de9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5328,10 +5328,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue)
53285328
len = 0;
53295329
}
53305330

5331+
read_again:
53315332
if (count >= limit)
53325333
break;
53335334

5334-
read_again:
53355335
buf1_len = 0;
53365336
buf2_len = 0;
53375337
entry = next_entry;

0 commit comments

Comments
 (0)