Skip to content

Commit fa7e6ab

Browse files
Jingwen Chenalexdeucher
authored andcommitted
drm/amd/amdgpu: fix refcount leak
[Why] the gem object rfb->base.obj[0] is get according to num_planes in amdgpufb_create, but is not put according to num_planes [How] put rfb->base.obj[0] in amdgpu_fbdev_destroy according to num_planes Signed-off-by: Jingwen Chen <Jingwen.Chen2@amd.com> Acked-by: Christian König <christian.koenig@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 0800392 commit fa7e6ab

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,10 +288,13 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
288288
static int amdgpu_fbdev_destroy(struct drm_device *dev, struct amdgpu_fbdev *rfbdev)
289289
{
290290
struct amdgpu_framebuffer *rfb = &rfbdev->rfb;
291+
int i;
291292

292293
drm_fb_helper_unregister_fbi(&rfbdev->helper);
293294

294295
if (rfb->base.obj[0]) {
296+
for (i = 0; i < rfb->base.format->num_planes; i++)
297+
drm_gem_object_put(rfb->base.obj[0]);
295298
amdgpufb_destroy_pinned_object(rfb->base.obj[0]);
296299
rfb->base.obj[0] = NULL;
297300
drm_framebuffer_unregister_private(&rfb->base);

0 commit comments

Comments
 (0)