Skip to content

Commit fac760f

Browse files
lalitshankarchaalexandrovich
authored andcommitted
fs/ntfs3: Use wait_on_buffer() directly
wait_on_buffer() checks buffer_locked() internally before calling __wait_on_buffer(). Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
1 parent f223ebf commit fac760f

3 files changed

Lines changed: 7 additions & 17 deletions

File tree

fs/ntfs3/fsntfs.c

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -875,9 +875,7 @@ void ntfs_update_mftmirr(struct ntfs_sb_info *sbi, int wait)
875875
return;
876876
}
877877

878-
if (buffer_locked(bh2))
879-
__wait_on_buffer(bh2);
880-
878+
wait_on_buffer(bh2);
881879
lock_buffer(bh2);
882880
memcpy(bh2->b_data, bh1->b_data, blocksize);
883881
set_buffer_uptodate(bh2);
@@ -1069,9 +1067,7 @@ int ntfs_sb_write(struct super_block *sb, u64 lbo, size_t bytes,
10691067
return -ENOMEM;
10701068
}
10711069

1072-
if (buffer_locked(bh))
1073-
__wait_on_buffer(bh);
1074-
1070+
wait_on_buffer(bh);
10751071
lock_buffer(bh);
10761072
if (buf) {
10771073
memcpy(bh->b_data + off, buf, op);
@@ -1347,8 +1343,8 @@ int ntfs_get_bh(struct ntfs_sb_info *sbi, const struct runs_tree *run, u64 vbo,
13471343
err = -ENOMEM;
13481344
goto out;
13491345
}
1350-
if (buffer_locked(bh))
1351-
__wait_on_buffer(bh);
1346+
1347+
wait_on_buffer(bh);
13521348

13531349
lock_buffer(bh);
13541350
if (!buffer_uptodate(bh))
@@ -1427,9 +1423,7 @@ int ntfs_write_bh(struct ntfs_sb_info *sbi, struct NTFS_RECORD_HEADER *rhdr,
14271423
if (op > bytes)
14281424
op = bytes;
14291425

1430-
if (buffer_locked(bh))
1431-
__wait_on_buffer(bh);
1432-
1426+
wait_on_buffer(bh);
14331427
lock_buffer(bh);
14341428

14351429
bh_data = bh->b_data + off;

fs/ntfs3/index.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,7 @@ static int bmp_buf_get(struct ntfs_index *indx, struct ntfs_inode *ni,
252252

253253
bbuf->bh = bh;
254254

255-
if (buffer_locked(bh))
256-
__wait_on_buffer(bh);
257-
255+
wait_on_buffer(bh);
258256
lock_buffer(bh);
259257

260258
sb = sbi->sb;

fs/ntfs3/super.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1652,9 +1652,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
16521652
*/
16531653
struct buffer_head *bh0 = sb_getblk(sb, 0);
16541654
if (bh0) {
1655-
if (buffer_locked(bh0))
1656-
__wait_on_buffer(bh0);
1657-
1655+
wait_on_buffer(bh0);
16581656
lock_buffer(bh0);
16591657
memcpy(bh0->b_data, boot2, sizeof(*boot2));
16601658
set_buffer_uptodate(bh0);

0 commit comments

Comments
 (0)