Skip to content

Commit fb5bd85

Browse files
Nitesh Narayan LalKAGA-KOKO
authored andcommitted
RDMA/irdma: Use irq_update_affinity_hint()
The driver uses irq_set_affinity_hint() to update the affinity_hint mask that is consumed by the userspace to distribute the interrupts. However, under the hood irq_set_affinity_hint() also applies the provided cpumask (if not NULL) as the affinity for the given interrupt which is an undocumented side effect. To remove this side effect irq_set_affinity_hint() has been marked as deprecated and new interfaces have been introduced. Hence, replace the irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that only updates the affinity_hint pointer. Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com> Link: https://lore.kernel.org/r/20210903152430.244937-7-nitesh@redhat.com
1 parent fdb8ed1 commit fb5bd85

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • drivers/infiniband/hw/irdma

drivers/infiniband/hw/irdma/hw.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
545545
struct irdma_sc_dev *dev = &rf->sc_dev;
546546

547547
dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx);
548-
irq_set_affinity_hint(msix_vec->irq, NULL);
548+
irq_update_affinity_hint(msix_vec->irq, NULL);
549549
free_irq(msix_vec->irq, dev_id);
550550
}
551551

@@ -1095,7 +1095,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf, struct irdma_ceq *iwceq,
10951095
}
10961096
cpumask_clear(&msix_vec->mask);
10971097
cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask);
1098-
irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask);
1098+
irq_update_affinity_hint(msix_vec->irq, &msix_vec->mask);
10991099
if (status) {
11001100
ibdev_dbg(&rf->iwdev->ibdev, "ERR: ceq irq config fail\n");
11011101
return IRDMA_ERR_CFG;

0 commit comments

Comments
 (0)