Skip to content

Commit fb7b9b0

Browse files
vincentkfuaxboe
authored andcommitted
kyber: make trace_block_rq call consistent with documentation
The kyber ioscheduler calls trace_block_rq_insert() *after* the request is added to the queue but the documentation for trace_block_rq_insert() says that the call should be made *before* the request is added to the queue. Move the tracepoint for the kyber ioscheduler so that it is consistent with the documentation. Signed-off-by: Vincent Fu <vincent.fu@samsung.com> Link: https://lore.kernel.org/r/20210804194913.10497-1-vincent.fu@samsung.com Reviewed by: Adam Manzanares <a.manzanares@samsung.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 2e9fb2c commit fb7b9b0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

block/kyber-iosched.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,13 +596,13 @@ static void kyber_insert_requests(struct blk_mq_hw_ctx *hctx,
596596
struct list_head *head = &kcq->rq_list[sched_domain];
597597

598598
spin_lock(&kcq->lock);
599+
trace_block_rq_insert(rq);
599600
if (at_head)
600601
list_move(&rq->queuelist, head);
601602
else
602603
list_move_tail(&rq->queuelist, head);
603604
sbitmap_set_bit(&khd->kcq_map[sched_domain],
604605
rq->mq_ctx->index_hw[hctx->type]);
605-
trace_block_rq_insert(rq);
606606
spin_unlock(&kcq->lock);
607607
}
608608
}

0 commit comments

Comments
 (0)