mtd: mtdoops: Fix the size of the header read buffer.

jmeurin · miquelraynal · commit fbb83e546ea4 · 2022-04-26T09:27:05.000+02:00
The read buffer size depends on the MTDOOPS_HEADER_SIZE. Tested: Changed the header size, it doesn't panic, header is still read/written correctly. Signed-off-by: Jean-Marc Eurin <jmeurin@google.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20220421234244.2172003-2-jmeurin@google.com
diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
@@ -223,7 +223,7 @@ static void find_next_position(struct mtdoops_context *cxt)
 {
 	struct mtd_info *mtd = cxt->mtd;
 	int ret, page, maxpos = 0;
-	u32 count[2], maxcount = 0xffffffff;
+	u32 count[MTDOOPS_HEADER_SIZE/sizeof(u32)], maxcount = 0xffffffff;
 	size_t retlen;
 
 	for (page = 0; page < cxt->oops_pages; page++) {

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ static void find_next_position(struct mtdoops_context *cxt)`
`223`	`223`	`{`
`224`	`224`	`struct mtd_info *mtd = cxt->mtd;`
`225`	`225`	`int ret, page, maxpos = 0;`
`226`		`- u32 count[2], maxcount = 0xffffffff;`
	`226`	`+ u32 count[MTDOOPS_HEADER_SIZE/sizeof(u32)], maxcount = 0xffffffff;`
`227`	`227`	`size_t retlen;`
`228`	`228`
`229`	`229`	`for (page = 0; page < cxt->oops_pages; page++) {`