Skip to content

Commit fbfd614

Browse files
khoroshilovgeertu
authored andcommitted
clk: renesas: cpg-mssr: Fix use after free if cpg_mssr_common_init() failed
If cpg_mssr_common_init() fails after assigning priv to global variable cpg_mssr_priv, it deallocates priv, but cpg_mssr_priv keeps dangling pointer that potentially can be used later. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 1f7db7b ("clk: renesas: cpg-mssr: Add early clock support") Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/1671806417-32623-1-git-send-email-khoroshilov@ispras.ru Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
1 parent a278d0c commit fbfd614

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/clk/renesas/renesas-cpg-mssr.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -989,7 +989,6 @@ static int __init cpg_mssr_common_init(struct device *dev,
989989
goto out_err;
990990
}
991991

992-
cpg_mssr_priv = priv;
993992
priv->num_core_clks = info->num_total_core_clks;
994993
priv->num_mod_clks = info->num_hw_mod_clks;
995994
priv->last_dt_core_clk = info->last_dt_core_clk;
@@ -1019,6 +1018,8 @@ static int __init cpg_mssr_common_init(struct device *dev,
10191018
if (error)
10201019
goto out_err;
10211020

1021+
cpg_mssr_priv = priv;
1022+
10221023
return 0;
10231024

10241025
out_err:

0 commit comments

Comments
 (0)