Skip to content

Commit fd0a133

Browse files
ColinIanKingbrauner
authored andcommitted
fs/direct-io: remove redundant assignment to variable retval
The variable retval is being assigned a value that is not being read, it is being re-assigned later on in the function. The assignment is redundant and can be removed. Cleans up clang scan build warning: fs/direct-io.c:1220:2: warning: Value stored to 'retval' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20240410162221.292485-1-colin.i.king@gmail.com Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 8bfb40b commit fd0a133

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

fs/direct-io.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1217,7 +1217,6 @@ ssize_t __blockdev_direct_IO(struct kiocb *iocb, struct inode *inode,
12171217
*/
12181218
inode_dio_begin(inode);
12191219

1220-
retval = 0;
12211220
sdio.blkbits = blkbits;
12221221
sdio.blkfactor = i_blkbits - blkbits;
12231222
sdio.block_in_file = offset >> blkbits;

0 commit comments

Comments
 (0)