Skip to content

Commit fd819ad

Browse files
stonezdmkuba-moo
authored andcommitted
ax25: fix use-after-free bugs caused by ax25_ds_del_timer
When the ax25 device is detaching, the ax25_dev_device_down() calls ax25_ds_del_timer() to cleanup the slave_timer. When the timer handler is running, the ax25_ds_del_timer() that calls del_timer() in it will return directly. As a result, the use-after-free bugs could happen, one of the scenarios is shown below: (Thread 1) | (Thread 2) | ax25_ds_timeout() ax25_dev_device_down() | ax25_ds_del_timer() | del_timer() | ax25_dev_put() //FREE | | ax25_dev-> //USE In order to mitigate bugs, when the device is detaching, use timer_shutdown_sync() to stop the timer. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20240329015023.9223-1-duoming@zju.edu.cn Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ea2a1cf commit fd819ad

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/ax25/ax25_dev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ void ax25_dev_device_down(struct net_device *dev)
105105
spin_lock_bh(&ax25_dev_lock);
106106

107107
#ifdef CONFIG_AX25_DAMA_SLAVE
108-
ax25_ds_del_timer(ax25_dev);
108+
timer_shutdown_sync(&ax25_dev->dama.slave_timer);
109109
#endif
110110

111111
/*

0 commit comments

Comments
 (0)