Skip to content

Commit fdce161

Browse files
rddunlapnmenon
authored andcommitted
firmware: ti_sci.h: fix all kernel-doc warnings
Modify kernel-doc comments in ti_sci.h to eliminate all kernel-doc warnings: * use correct/matching struct names in kdoc comments * use correct struct member names in kdoc comments * add a ':' after struct member names where needed * change a blank kdoc line to " *" * convert 3 structs to kernel-doc comments: struct ti_sci_msg_rm_udmap_tx_ch_cfg_req struct ti_sci_msg_rm_udmap_rx_ch_cfg_req struct ti_sci_msg_rm_udmap_flow_cfg_req Fixes 13 kernel-doc warnings: Warning: drivers/firmware/ti_sci.h:609 expecting prototype for struct tisci_msg_req_prepare_sleep. Prototype was for struct ti_sci_msg_req_prepare_sleep instead Warning: drivers/firmware/ti_sci.h:609 struct member 'hdr' not described in 'ti_sci_msg_req_prepare_sleep' Warning: drivers/firmware/ti_sci.h:609 struct member 'mode' not described in 'ti_sci_msg_req_prepare_sleep' Warning: drivers/firmware/ti_sci.h:609 struct member 'ctx_lo' not described in 'ti_sci_msg_req_prepare_sleep' Warning: drivers/firmware/ti_sci.h:609 struct member 'ctx_hi' not described in 'ti_sci_msg_req_prepare_sleep' Warning: drivers/firmware/ti_sci.h:609 struct member 'debug_flags' not described in 'ti_sci_msg_req_prepare_sleep' Warning: drivers/firmware/ti_sci.h:623 expecting prototype for struct tisci_msg_set_io_isolation_req. Prototype was for struct ti_sci_msg_req_set_io_isolation instead Warning: drivers/firmware/ti_sci.h:696 struct member 'latency' not described in 'ti_sci_msg_req_lpm_set_latency_constraint' Warning: drivers/firmware/ti_sci.h:857 bad line: Warning: drivers/firmware/ti_sci.h:1002 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst * Configures a Navigator Subsystem UDMAP transmit channel Warning: drivers/firmware/ti_sci.h:1130 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst * Configures a Navigator Subsystem UDMAP receive channel Warning: drivers/firmware/ti_sci.h:1249 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst * Configures a Navigator Subsystem UDMAP receive flow Warning: drivers/firmware/ti_sci.h:1421 struct member 'valid_params' not described in 'ti_sci_msg_rm_udmap_flow_cfg_req' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Link: https://patch.msgid.link/20251128055731.812460-1-rdunlap@infradead.org Signed-off-by: Nishanth Menon <nm@ti.com>
1 parent 8f0b4cc commit fdce161

1 file changed

Lines changed: 16 additions & 13 deletions

File tree

drivers/firmware/ti_sci.h

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -580,13 +580,13 @@ struct ti_sci_msg_resp_get_clock_freq {
580580
} __packed;
581581

582582
/**
583-
* struct tisci_msg_req_prepare_sleep - Request for TISCI_MSG_PREPARE_SLEEP.
583+
* struct ti_sci_msg_req_prepare_sleep - Request for TISCI_MSG_PREPARE_SLEEP.
584584
*
585-
* @hdr TISCI header to provide ACK/NAK flags to the host.
586-
* @mode Low power mode to enter.
587-
* @ctx_lo Low 32-bits of physical pointer to address to use for context save.
588-
* @ctx_hi High 32-bits of physical pointer to address to use for context save.
589-
* @debug_flags Flags that can be set to halt the sequence during suspend or
585+
* @hdr: TISCI header to provide ACK/NAK flags to the host.
586+
* @mode: Low power mode to enter.
587+
* @ctx_lo: Low 32-bits of physical pointer to address to use for context save.
588+
* @ctx_hi: High 32-bits of physical pointer to address to use for context save.
589+
* @debug_flags: Flags that can be set to halt the sequence during suspend or
590590
* resume to allow JTAG connection and debug.
591591
*
592592
* This message is used as the first step of entering a low power mode. It
@@ -610,7 +610,7 @@ struct ti_sci_msg_req_prepare_sleep {
610610
} __packed;
611611

612612
/**
613-
* struct tisci_msg_set_io_isolation_req - Request for TI_SCI_MSG_SET_IO_ISOLATION.
613+
* struct ti_sci_msg_req_set_io_isolation - Request for TI_SCI_MSG_SET_IO_ISOLATION.
614614
*
615615
* @hdr: Generic header
616616
* @state: The deseared state of the IO isolation.
@@ -676,7 +676,7 @@ struct ti_sci_msg_req_lpm_set_device_constraint {
676676
* TISCI_MSG_LPM_SET_LATENCY_CONSTRAINT.
677677
*
678678
* @hdr: TISCI header to provide ACK/NAK flags to the host.
679-
* @wkup_latency: The maximum acceptable latency to wake up from low power mode
679+
* @latency: The maximum acceptable latency to wake up from low power mode
680680
* in milliseconds. The deeper the state, the higher the latency.
681681
* @state: The desired state of wakeup latency constraint: set or clear.
682682
* @rsvd: Reserved for future use.
@@ -855,7 +855,7 @@ struct ti_sci_msg_rm_ring_cfg_req {
855855
* UDMAP transmit channels mapped to source threads will have their
856856
* TCHAN_THRD_ID register programmed with the destination thread if the pairing
857857
* is successful.
858-
858+
*
859859
* @dst_thread: PSI-L destination thread ID within the PSI-L System thread map.
860860
* PSI-L destination threads start at index 0x8000. The request is NACK'd if
861861
* the destination thread is not greater than or equal to 0x8000.
@@ -1000,7 +1000,8 @@ struct rm_ti_sci_msg_udmap_rx_flow_opt_cfg {
10001000
} __packed;
10011001

10021002
/**
1003-
* Configures a Navigator Subsystem UDMAP transmit channel
1003+
* struct ti_sci_msg_rm_udmap_tx_ch_cfg_req - Configures a
1004+
* Navigator Subsystem UDMAP transmit channel
10041005
*
10051006
* Configures the non-real-time registers of a Navigator Subsystem UDMAP
10061007
* transmit channel. The channel index must be assigned to the host defined
@@ -1128,7 +1129,8 @@ struct ti_sci_msg_rm_udmap_tx_ch_cfg_req {
11281129
} __packed;
11291130

11301131
/**
1131-
* Configures a Navigator Subsystem UDMAP receive channel
1132+
* struct ti_sci_msg_rm_udmap_rx_ch_cfg_req - Configures a
1133+
* Navigator Subsystem UDMAP receive channel
11321134
*
11331135
* Configures the non-real-time registers of a Navigator Subsystem UDMAP
11341136
* receive channel. The channel index must be assigned to the host defined
@@ -1247,7 +1249,8 @@ struct ti_sci_msg_rm_udmap_rx_ch_cfg_req {
12471249
} __packed;
12481250

12491251
/**
1250-
* Configures a Navigator Subsystem UDMAP receive flow
1252+
* struct ti_sci_msg_rm_udmap_flow_cfg_req - Configures a
1253+
* Navigator Subsystem UDMAP receive flow
12511254
*
12521255
* Configures a Navigator Subsystem UDMAP receive flow's registers.
12531256
* Configuration does not include the flow registers which handle size-based
@@ -1258,7 +1261,7 @@ struct ti_sci_msg_rm_udmap_rx_ch_cfg_req {
12581261
*
12591262
* @hdr: Standard TISCI header
12601263
*
1261-
* @valid_params
1264+
* @valid_params:
12621265
* Bitfield defining validity of rx flow configuration parameters. The
12631266
* rx flow configuration fields are not valid, and will not be used for flow
12641267
* configuration, if their corresponding valid bit is zero. Valid bit usage:

0 commit comments

Comments
 (0)