f2fs: fix error path handling in f2fs_read_data_large_folio()

chaseyu · Jaegeuk Kim · commit fe15bc3d447c · 2026-01-19T17:07:47.000Z
In error path of f2fs_read_data_large_folio(), if bio is valid, it
may submit bio twice, fix it.

Signed-off-by: Chao Yu &lt;chao@kernel.org&gt;
Signed-off-by: Jaegeuk Kim &lt;jaegeuk@kernel.org&gt;
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
@@ -2577,17 +2577,14 @@ static int f2fs_read_data_large_folio(struct inode *inode,
 		folio_end_read(folio, !ret);
 		return ret;
 	}
-
+out:
+	f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
 	if (ret) {
-		f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
-
 		/* Wait bios and clear uptodate. */
 		folio_lock(folio);
 		folio_clear_uptodate(folio);
 		folio_unlock(folio);
 	}
-out:
-	f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);
 	return ret;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2577,17 +2577,14 @@ static int f2fs_read_data_large_folio(struct inode *inode,`
`2577`	`2577`	`folio_end_read(folio, !ret);`
`2578`	`2578`	`return ret;`
`2579`	`2579`	`}`
`2580`		`-`
	`2580`	`+out:`
	`2581`	`+ f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);`
`2581`	`2582`	`if (ret) {`
`2582`		`- f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);`
`2583`		`-`
`2584`	`2583`	`/* Wait bios and clear uptodate. */`
`2585`	`2584`	`folio_lock(folio);`
`2586`	`2585`	`folio_clear_uptodate(folio);`
`2587`	`2586`	`folio_unlock(folio);`
`2588`	`2587`	`}`
`2589`		`-out:`
`2590`		`- f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA);`
`2591`	`2588`	`return ret;`
`2592`	`2589`	`}`
`2593`	`2590`