Skip to content

Commit fe1e7e8

Browse files
afiragobroonie
authored andcommitted
ASoC: codecs: es8326: Fix DTS properties reading
Seems like properties parsing and reading was copy-pasted, so "everest,interrupt-src" and "everest,interrupt-clk" are saved into the es8326->jack_pol variable. This might lead to wrong settings being saved into the reg 57 (ES8326_HP_DET). Fix this by using proper variables while reading properties. Signed-off-by: Alexey Firago <a.firago@yadro.com> Reviewed-by: Yang Yingliang <yangyingliang@huawei.com Link: https://lore.kernel.org/r/20230204195106.46539-1-a.firago@yadro.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 2e7c665 commit fe1e7e8

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

sound/soc/codecs/es8326.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -729,14 +729,16 @@ static int es8326_probe(struct snd_soc_component *component)
729729
}
730730
dev_dbg(component->dev, "jack-pol %x", es8326->jack_pol);
731731

732-
ret = device_property_read_u8(component->dev, "everest,interrupt-src", &es8326->jack_pol);
732+
ret = device_property_read_u8(component->dev, "everest,interrupt-src",
733+
&es8326->interrupt_src);
733734
if (ret != 0) {
734735
dev_dbg(component->dev, "interrupt-src return %d", ret);
735736
es8326->interrupt_src = ES8326_HP_DET_SRC_PIN9;
736737
}
737738
dev_dbg(component->dev, "interrupt-src %x", es8326->interrupt_src);
738739

739-
ret = device_property_read_u8(component->dev, "everest,interrupt-clk", &es8326->jack_pol);
740+
ret = device_property_read_u8(component->dev, "everest,interrupt-clk",
741+
&es8326->interrupt_clk);
740742
if (ret != 0) {
741743
dev_dbg(component->dev, "interrupt-clk return %d", ret);
742744
es8326->interrupt_clk = 0x45;

0 commit comments

Comments
 (0)