Skip to content

Commit fe2e59a

Browse files
Saravana Kannangregkh
authored andcommitted
drm: display: Set fwnode for aux bus devices
fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: mediatek-drm-dp 1c500000.edp-tx: Failed to create device link (0x180) with backlight-lcd0 Reported-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Closes: https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Signed-off-by: Saravana Kannan <saravanak@google.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Thierry Reding <treding@nvidia.com> Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20241024061347.1771063-2-saravanak@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent bac3b10 commit fe2e59a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/display/drm_dp_aux_bus.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ int of_dp_aux_populate_bus(struct drm_dp_aux *aux,
292292
aux_ep->dev.parent = aux->dev;
293293
aux_ep->dev.bus = &dp_aux_bus_type;
294294
aux_ep->dev.type = &dp_aux_device_type_type;
295-
aux_ep->dev.of_node = of_node_get(np);
295+
device_set_node(&aux_ep->dev, of_fwnode_handle(of_node_get(np)));
296296
dev_set_name(&aux_ep->dev, "aux-%s", dev_name(aux->dev));
297297

298298
ret = device_register(&aux_ep->dev);

0 commit comments

Comments
 (0)