drm/amd: Tighten permissions on VBIOS flashing attributes

superm1 · alexdeucher · commit fe56c6ee0457 · 2023-06-09T12:48:10.000-04:00
Non-root users shouldn't be able to try to trigger a VBIOS flash or query the flashing status. This should be reserved for users with the appropriate permissions. Cc: stable@vger.kernel.org Fixes: 8424f2c ("drm/amdgpu/psp: Add vbflash sysfs interface support") Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -3671,13 +3671,13 @@ static ssize_t amdgpu_psp_vbflash_status(struct device *dev,
 }
 
 static const struct bin_attribute psp_vbflash_bin_attr = {
-	.attr = {.name = "psp_vbflash", .mode = 0664},
+	.attr = {.name = "psp_vbflash", .mode = 0660},
 	.size = 0,
 	.write = amdgpu_psp_vbflash_write,
 	.read = amdgpu_psp_vbflash_read,
 };
 
-static DEVICE_ATTR(psp_vbflash_status, 0444, amdgpu_psp_vbflash_status, NULL);
+static DEVICE_ATTR(psp_vbflash_status, 0440, amdgpu_psp_vbflash_status, NULL);
 
 int amdgpu_psp_sysfs_init(struct amdgpu_device *adev)
 {

Original file line number	Diff line number	Diff line change
`@@ -3671,13 +3671,13 @@ static ssize_t amdgpu_psp_vbflash_status(struct device *dev,`
`3671`	`3671`	`}`
`3672`	`3672`
`3673`	`3673`	`static const struct bin_attribute psp_vbflash_bin_attr = {`
`3674`		`- .attr = {.name = "psp_vbflash", .mode = 0664},`
	`3674`	`+ .attr = {.name = "psp_vbflash", .mode = 0660},`
`3675`	`3675`	`.size = 0,`
`3676`	`3676`	`.write = amdgpu_psp_vbflash_write,`
`3677`	`3677`	`.read = amdgpu_psp_vbflash_read,`
`3678`	`3678`	`};`
`3679`	`3679`
`3680`		`-static DEVICE_ATTR(psp_vbflash_status, 0444, amdgpu_psp_vbflash_status, NULL);`
	`3680`	`+static DEVICE_ATTR(psp_vbflash_status, 0440, amdgpu_psp_vbflash_status, NULL);`
`3681`	`3681`
`3682`	`3682`	`int amdgpu_psp_sysfs_init(struct amdgpu_device *adev)`
`3683`	`3683`	`{`