Skip to content

Commit fe5bd82

Browse files
committed
auxdisplay: linedisp: Move exported symbols to a namespace
Avoid unnecessary pollution of the global symbol namespace by moving library functions in to a specific namespace and import that into the drivers that make use of the functions. For more info: https://lwn.net/Articles/760045/ Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Tested-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
1 parent 6134b0b commit fe5bd82

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/auxdisplay/ht16k33.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -831,4 +831,5 @@ module_i2c_driver(ht16k33_driver);
831831

832832
MODULE_DESCRIPTION("Holtek HT16K33 driver");
833833
MODULE_LICENSE("GPL");
834+
MODULE_IMPORT_NS(LINEDISP);
834835
MODULE_AUTHOR("Robin van der Gracht <robin@protonic.nl>");

drivers/auxdisplay/img-ascii-lcd.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,3 +298,4 @@ module_platform_driver(img_ascii_lcd_driver);
298298
MODULE_DESCRIPTION("Imagination Technologies ASCII LCD Display");
299299
MODULE_AUTHOR("Paul Burton <paul.burton@mips.com>");
300300
MODULE_LICENSE("GPL");
301+
MODULE_IMPORT_NS(LINEDISP);

drivers/auxdisplay/line-display.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ int linedisp_register(struct linedisp *linedisp, struct device *parent,
263263
put_device(&linedisp->dev);
264264
return err;
265265
}
266-
EXPORT_SYMBOL_GPL(linedisp_register);
266+
EXPORT_SYMBOL_NS_GPL(linedisp_register, LINEDISP);
267267

268268
/**
269269
* linedisp_unregister - unregister a character line display
@@ -276,6 +276,6 @@ void linedisp_unregister(struct linedisp *linedisp)
276276
del_timer_sync(&linedisp->timer);
277277
put_device(&linedisp->dev);
278278
}
279-
EXPORT_SYMBOL_GPL(linedisp_unregister);
279+
EXPORT_SYMBOL_NS_GPL(linedisp_unregister, LINEDISP);
280280

281281
MODULE_LICENSE("GPL");

0 commit comments

Comments
 (0)