Skip to content

Commit fe85a39

Browse files
ukleineklag-linaro
authored andcommitted
backlight: mp3309c: Initialize backlight properties without memset
Assigning values to a struct using a compound literal (since C99) also guarantees that all unspecified struct members are empty-initialized, so it properly replaces the memset to zero. The code looks a bit nicer and more idiomatic (though that might be subjective?). The resulting binary is a bit smaller. On ARCH=arm with an allnoconfig + minimal changes to enable the mp3309c driver the difference is 12 bytes. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Tested-by: Flavio Suligoi <f.suligoi@asem.it> Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org> Link: https://lore.kernel.org/r/14514a1b0d3df6438aa10bb74f1c4fc2367d9987.1751361465.git.u.kleine-koenig@baylibre.com Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 2720c87 commit fe85a39

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

drivers/video/backlight/mp3309c.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -352,12 +352,13 @@ static int mp3309c_probe(struct i2c_client *client)
352352
chip->pdata = pdata;
353353

354354
/* Backlight properties */
355-
memset(&props, 0, sizeof(struct backlight_properties));
356-
props.brightness = pdata->default_brightness;
357-
props.max_brightness = pdata->max_brightness;
358-
props.scale = BACKLIGHT_SCALE_LINEAR;
359-
props.type = BACKLIGHT_RAW;
360-
props.power = BACKLIGHT_POWER_ON;
355+
props = (typeof(props)){
356+
.brightness = pdata->default_brightness,
357+
.max_brightness = pdata->max_brightness,
358+
.scale = BACKLIGHT_SCALE_LINEAR,
359+
.type = BACKLIGHT_RAW,
360+
.power = BACKLIGHT_POWER_ON,
361+
};
361362
chip->bl = devm_backlight_device_register(dev, "mp3309c", dev, chip,
362363
&mp3309c_bl_ops, &props);
363364
if (IS_ERR(chip->bl))

0 commit comments

Comments
 (0)