Skip to content

Commit feff727

Browse files
committed
leds: pattern trigger -- check pattern for validity
Don't allow invalid brightness in the pattern. Signed-off-by: Pavel Machek <pavel@ucw.cz>
1 parent c543733 commit feff727

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/leds/trigger/ledtrig-pattern.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,12 @@ static int pattern_trig_store_patterns_string(struct pattern_trig_data *data,
227227

228228
while (offset < count - 1 && data->npatterns < MAX_PATTERNS) {
229229
cr = 0;
230-
ccount = sscanf(buf + offset, "%d %u %n",
230+
ccount = sscanf(buf + offset, "%u %u %n",
231231
&data->patterns[data->npatterns].brightness,
232232
&data->patterns[data->npatterns].delta_t, &cr);
233-
if (ccount != 2) {
233+
234+
if (ccount != 2 ||
235+
data->patterns[data->npatterns].brightness > data->led_cdev->max_brightness) {
234236
data->npatterns = 0;
235237
return -EINVAL;
236238
}

0 commit comments

Comments
 (0)