Skip to content

Commit ff24e5b

Browse files
MrVanmathieupoirier
authored andcommitted
remoteproc: imx_rproc: Introduce start/stop/detect_mode ops for imx_rproc_dcfg
Simplify the logic in imx_rproc_start(), imx_rproc_stop() and imx_rproc_detect_mode(), introduce start, stop and detect_mode ops for the imx_rproc_dcfg structure. Allow each platform to provide its own implementation of start/stop/detect_mode operations, and prepare to eliminate the need for multiple switch-case statements. Improve code readability and maintainability by encapsulating platform-specific behavior. No functional changes. Reviewed-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> Link: https://lore.kernel.org/r/20250910-imx-rproc-cleanup-v2-1-10386685b8a9@nxp.com Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent 2433961 commit ff24e5b

2 files changed

Lines changed: 22 additions & 0 deletions

File tree

drivers/remoteproc/imx_rproc.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,11 @@ static int imx_rproc_start(struct rproc *rproc)
376376
if (ret)
377377
return ret;
378378

379+
if (dcfg->ops && dcfg->ops->start) {
380+
ret = dcfg->ops->start(rproc);
381+
goto start_ret;
382+
}
383+
379384
switch (dcfg->method) {
380385
case IMX_RPROC_MMIO:
381386
if (priv->gpr) {
@@ -398,6 +403,7 @@ static int imx_rproc_start(struct rproc *rproc)
398403
return -EOPNOTSUPP;
399404
}
400405

406+
start_ret:
401407
if (ret)
402408
dev_err(dev, "Failed to enable remote core!\n");
403409

@@ -412,6 +418,11 @@ static int imx_rproc_stop(struct rproc *rproc)
412418
struct arm_smccc_res res;
413419
int ret;
414420

421+
if (dcfg->ops && dcfg->ops->stop) {
422+
ret = dcfg->ops->stop(rproc);
423+
goto stop_ret;
424+
}
425+
415426
switch (dcfg->method) {
416427
case IMX_RPROC_MMIO:
417428
if (priv->gpr) {
@@ -440,6 +451,7 @@ static int imx_rproc_stop(struct rproc *rproc)
440451
return -EOPNOTSUPP;
441452
}
442453

454+
stop_ret:
443455
if (ret)
444456
dev_err(dev, "Failed to stop remote core\n");
445457
else
@@ -933,6 +945,9 @@ static int imx_rproc_detect_mode(struct imx_rproc *priv)
933945
u32 val;
934946
u8 pt;
935947

948+
if (dcfg->ops && dcfg->ops->detect_mode)
949+
return dcfg->ops->detect_mode(priv->rproc);
950+
936951
switch (dcfg->method) {
937952
case IMX_RPROC_NONE:
938953
priv->rproc->state = RPROC_DETACHED;

drivers/remoteproc/imx_rproc.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,12 @@ enum imx_rproc_method {
3131
/* dcfg flags */
3232
#define IMX_RPROC_NEED_SYSTEM_OFF BIT(0)
3333

34+
struct imx_rproc_plat_ops {
35+
int (*start)(struct rproc *rproc);
36+
int (*stop)(struct rproc *rproc);
37+
int (*detect_mode)(struct rproc *rproc);
38+
};
39+
3440
struct imx_rproc_dcfg {
3541
u32 src_reg;
3642
u32 src_mask;
@@ -42,6 +48,7 @@ struct imx_rproc_dcfg {
4248
size_t att_size;
4349
enum imx_rproc_method method;
4450
u32 flags;
51+
const struct imx_rproc_plat_ops *ops;
4552
};
4653

4754
#endif /* _IMX_RPROC_H */

0 commit comments

Comments
 (0)