Skip to content

Commit ff24f31

Browse files
dedekindrafaeljw
authored andcommitted
intel_idle: Initialize sysfs after cpuidle driver initialization
Reorder initialization calls to initialize the internal driver data before sysfs: Was: intel_idle_sysfs_init(); intel_idle_cpuidle_driver_init(); Now: intel_idle_cpuidle_driver_init(); intel_idle_sysfs_init(); Follow the general principle that drivers should initialize internal state before registering external interfaces like sysfs, avoiding potential usage before full initialization. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Link: https://patch.msgid.link/20251216080402.156988-2-dedekind1@gmail.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent a36dc37 commit ff24f31

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/idle/intel_idle.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2455,12 +2455,12 @@ static int __init intel_idle_init(void)
24552455
if (!intel_idle_cpuidle_devices)
24562456
return -ENOMEM;
24572457

2458+
intel_idle_cpuidle_driver_init(&intel_idle_driver);
2459+
24582460
retval = intel_idle_sysfs_init();
24592461
if (retval)
24602462
pr_warn("failed to initialized sysfs");
24612463

2462-
intel_idle_cpuidle_driver_init(&intel_idle_driver);
2463-
24642464
retval = cpuidle_register_driver(&intel_idle_driver);
24652465
if (retval) {
24662466
struct cpuidle_driver *drv = cpuidle_get_driver();

0 commit comments

Comments
 (0)