Skip to content

Commit ff399ba

Browse files
harperchengregkh
authored andcommitted
usb: gadget: legacy: fix error return code in gfs_bind
We must return negative error code -ENOMEM if function 'usb_otg_descriptor_alloc()' fails. Signed-off-by: Wei Chen <harperchen1110@gmail.com> Link: https://lore.kernel.org/r/20230621124323.47183-1-harperchen1110@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ef1e29c commit ff399ba

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/usb/gadget/legacy/g_ffs.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,8 +389,10 @@ static int gfs_bind(struct usb_composite_dev *cdev)
389389
struct usb_descriptor_header *usb_desc;
390390

391391
usb_desc = usb_otg_descriptor_alloc(cdev->gadget);
392-
if (!usb_desc)
392+
if (!usb_desc) {
393+
ret = -ENOMEM;
393394
goto error_rndis;
395+
}
394396
usb_otg_descriptor_init(cdev->gadget, usb_desc);
395397
gfs_otg_desc[0] = usb_desc;
396398
gfs_otg_desc[1] = NULL;

0 commit comments

Comments
 (0)