Remove static mutable state from LibCpp2IL 2: Electric Boogaloo#542
Merged
Merged
Conversation
Coverage Report for CI Build 25641285720Coverage decreased (-0.2%) to 35.104%Details
Uncovered Changes
Coverage Regressions12 previously-covered lines in 11 files lost coverage.
Coverage Stats
💛 - Coveralls |
Xpl0itR
force-pushed
the
instanced-state
branch
from
0799bab to
51d6bf1
Compare
Xpl0itR
force-pushed
the
instanced-state
branch
from
51d6bf1 to
32624b1
Compare
SamboyCoding
approved these changes
Jun 7, 2026
|
|
||
| ConfigureLib(allowUserToInputAddresses); | ||
|
|
||
| #if !DEBUG |
Owner
There was a problem hiding this comment.
These got dropped, need to bring them back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Remove Static State
Overview
Eliminated static/global state across the codebase by moving state into
LibCpp2IlContext. This enables multiple concurrent analysis sessions and improves testability.What Changed
Deleted:
LibCpp2IlGlobalMapper.cs— static mapper moved to contextRefactored:
LibCpp2IlContextnow owns all global mapper state (TypeRefs, MethodRefs, FieldRefs, Literals)LibCpp2IlMainmarked[Obsolete]for backwards compatibility