Skip to content

Commit 2e5ca04

Browse files
simplify valueexpressioncontext
1 parent 0f4a730 commit 2e5ca04

1 file changed

Lines changed: 17 additions & 19 deletions

File tree

Code/ContextSystem/Contexts/ValueExpressionContext.cs

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -42,21 +42,20 @@ public ValueExpressionContext(BaseToken initial, bool allowsYielding)
4242
_initial = initial;
4343
try
4444
{
45-
if (initial is MethodToken methodToken)
45+
switch (initial)
4646
{
47-
_handler = new MethodHandler(methodToken, allowsYielding, initial.Script);
48-
}
49-
else if (initial is RunFunctionToken)
50-
{
51-
_handler = new FunctionCallHandler(initial.Script);
52-
}
53-
else if (initial is not IValueToken valToken)
54-
{
55-
_error = $"{initial} is not a valid way to get a value.";
56-
}
57-
else
58-
{
59-
_initialValueToken = valToken;
47+
case MethodToken methodToken:
48+
_handler = new MethodHandler(methodToken, allowsYielding, initial.Script);
49+
break;
50+
case RunFunctionToken:
51+
_handler = new FunctionCallHandler(initial.Script);
52+
break;
53+
case IValueToken valToken:
54+
_initialValueToken = valToken;
55+
break;
56+
default:
57+
_error = $"{initial} is not a valid way to get a value.";
58+
break;
6059
}
6160
}
6261
catch (Exception e)
@@ -356,14 +355,13 @@ public override TryAddTokenRes TryAddToken(BaseToken token)
356355
{
357356
if (_func is null)
358357
{
359-
if (scr.DefinedFunctions.TryGetValue(token.RawRep, out var func))
360-
{
361-
_func = func;
362-
}
363-
else
358+
if (!scr.DefinedFunctions.TryGetValue(token.RawRep, out var func))
364359
{
365360
return TryAddTokenRes.Error($"Function '{token.RawRep}' is not defined.");
366361
}
362+
363+
_func = func;
364+
return TryAddTokenRes.Continue();
367365
}
368366

369367
if (token is IValueToken valToken)

0 commit comments

Comments
 (0)