make errors in OnSuccess be not required

Author: Elektryk-Andrzej

Code/ArgumentSystem/Arguments/FloatArgument.cs

@@ -58,7 +58,7 @@ public DynamicTryGet<float> GetConvertSolution(BaseToken token)
             return VerifyRange(number.Value.Value);
         }
 
-        return new(() => token.TryGetLiteralValue<NumberValue>().OnSuccess(VerifyRange, null));
+        return new(() => token.TryGetLiteralValue<NumberValue>().OnSuccess(VerifyRange));
     }
 
     private TryGet<float> VerifyRange(NumberValue value)

Code/ArgumentSystem/Arguments/IntArgument.cs

@@ -56,7 +56,7 @@ public DynamicTryGet<int> GetConvertSolution(BaseToken token)
         {
             return VerifyRange(number.Value.Value);
         }
-        return new(() => token.TryGetLiteralValue<NumberValue>().OnSuccess(VerifyRange, null));
+        return new(() => token.TryGetLiteralValue<NumberValue>().OnSuccess(VerifyRange));
     }
 
     private TryGet<int> VerifyRange(NumberValue value)

Code/ArgumentSystem/Arguments/IsValidReferenceArgument.cs

@@ -19,6 +19,6 @@ public DynamicTryGet<bool> GetConvertSolution(BaseToken token)
             return $"Value '{token.RawRep}' is not a reference.";
         }
 
-        return new(() => func().OnSuccess(v => v.IsValid, null));
+        return new(() => func().OnSuccess(v => v.IsValid));
     }
 }

Code/ArgumentSystem/Arguments/LooseReferenceArgument.cs

@@ -20,7 +20,7 @@ public virtual DynamicTryGet<object> GetConvertSolution(BaseToken token)
             return $"Value '{token.RawRep}' does not represent a valid reference.";
         }
 
-        return new(() => get().OnSuccess(rv => TryParse(rv, type), null));
+        return new(() => get().OnSuccess(rv => TryParse(rv, type)));
     }
 
     public TryGet<object> TryParse(ReferenceValue value, Type targetType)
@@ -48,7 +48,7 @@ public class ReferenceArgument<TValue>(string name) : LooseReferenceArgument(nam
             return $"Value '{token.RawRep}' does not represent a valid reference.";
         }
 
-        return new(() => get().OnSuccess(TryParse, null));
+        return new(() => get().OnSuccess(TryParse));
     }
 
     public static TryGet<TValue> TryParse(ReferenceValue value)

Code/ArgumentSystem/Arguments/PlayersArgument.cs

@@ -26,7 +26,7 @@ public DynamicTryGet<Player[]> GetConvertSolution(BaseToken token)
             return $"Value '{token.RawRep}' does not represent a valid player variable.";
         }
 
-        return new(() => get().OnSuccess(v => v.Players, null));
+        return new(() => get().OnSuccess(v => v.Players));
     }
 }
 

Code/ArgumentSystem/Arguments/TextArgument.cs

@@ -19,7 +19,7 @@ public DynamicTryGet<string> GetConvertSolution(BaseToken token)
     {
         if (token is TextToken textToken)
         {
-            return new(() => textToken.GetDynamicResolver().Invoke().OnSuccess(SpaceCheck, null));
+            return new(() => textToken.GetDynamicResolver().Invoke().OnSuccess(SpaceCheck));
         }    
 
         if (token is not IValueToken valToken || !valToken.CapableOf<LiteralValue>(out var get))
@@ -34,10 +34,10 @@ public DynamicTryGet<string> GetConvertSolution(BaseToken token)
 
         if (valToken.IsConstant)
         {
-            return SpaceCheck(get().OnSuccess(v => v.StringRep, null));
+            return SpaceCheck(get().OnSuccess(v => v.StringRep));
         }
 
-        return new(() => get().OnSuccess(v => SpaceCheck(v.StringRep), null));
+        return new(() => get().OnSuccess(v => SpaceCheck(v.StringRep)));
 
         TryGet<string> SpaceCheck(string value)
         {

Code/Extensions/SerExtensions.cs

@@ -13,12 +13,12 @@ public static TryGet<TOut> SuccessTryCast<TIn, TOut>(this TryGet<TIn> value)
         where TIn : notnull
         where TOut : TIn
     {
-        return value.OnSuccess(v => v.TryCast<TOut>(), null);
+        return value.OnSuccess(v => v.TryCast<TOut>());
     }
 
     public static TryGet<TOut> SuccessTryCast<TOut>(this TryGet<Value> value) where TOut : Value
     {
-        return value.OnSuccess(v => v.TryCast<TOut>(), null);
+        return value.OnSuccess(v => v.TryCast<TOut>());
     }
 
     public static TryGet<TOut> TryCast<TOut>(this object value, string rawRep = "")

Code/Helpers/ResultSystem/TryGet.cs

@@ -84,7 +84,7 @@ public static TryGet<TValue> Success(TValue value)
     }
 
     [Pure]
-    public TryGet<TTarget> OnSuccess<TTarget>(Func<TValue, TTarget> transform, string? mainErr)
+    public TryGet<TTarget> OnSuccess<TTarget>(Func<TValue, TTarget> transform, string? mainErr = null)
     {
         if (HasErrored(out var error, out var val))
         {
@@ -98,7 +98,7 @@ public TryGet<TTarget> OnSuccess<TTarget>(Func<TValue, TTarget> transform, strin
     }
 
     [Pure]
-    public TryGet<TTarget> OnSuccess<TTarget>(Func<TValue, TryGet<TTarget>> transform, string? mainErr)
+    public TryGet<TTarget> OnSuccess<TTarget>(Func<TValue, TryGet<TTarget>> transform, string? mainErr = null)
     {
         if (HasErrored(out var error, out var val))
         {

Code/TokenSystem/Tokens/VariableTokens/VariableToken.cs

@@ -50,7 +50,7 @@ public abstract class VariableToken<TVariable, TValue> : VariableToken, IValueTo
         return Script.TryGetVariable<TVariable>(this);
     }
 
-    public TryGet<TValue> ExactValue => TryGetVariable().OnSuccess(variable => variable.Value, null);
+    public TryGet<TValue> ExactValue => TryGetVariable().OnSuccess(variable => variable.Value);
 
     protected override IParseResult InternalParse(Script scr)
     {
@@ -70,7 +70,7 @@ protected override IParseResult InternalParse(Script scr)
 
     public TryGet<Value> Value()
     {
-        return TryGetVariable().OnSuccess(Value (variable) => variable.Value, null);
+        return TryGetVariable().OnSuccess(Value (variable) => variable.Value);
     }
 
     public TypeOfValue PossibleValues => new TypeOfValue<TValue>();