Adds tests for promise interface in addition to the callback interface

Author: beaucollins

test/simperium/bucket_test.js

@@ -1,70 +1,102 @@
-import assert from 'assert'
-import Bucket from '../../src/simperium/bucket'
-import storeProvider from './mock_bucket_store'
+import { ok, equal, deepEqual } from 'assert';
 
-describe( 'Bucket', function() {
-	var bucket, store;
+import Bucket from '../../src/simperium/bucket';
+import storeProvider from './mock_bucket_store';
+import { MockChannel } from './mock-channel';
+
+describe( 'Bucket', () => {
+	let bucket, store;
 
 	beforeEach( function() {
-		bucket = new Bucket( 'things', storeProvider );
+		bucket = new Bucket( 'things', storeProvider, new MockChannel() );
 		store = bucket.store;
 	} );
 
-	it( 'should fetch object data', function( done ) {
+	it( 'should fetch object data callback', function( done ) {
 		var object = {title: 'hi'};
 		store.objects = {
 			hello: object
 		};
 
-		bucket.get( 'hello', function( e, found ) {
-			assert.deepEqual( found, object );
+		bucket.get( 'hello', ( e, found ) => {
+			deepEqual( found, object );
 			done();
 		} );
 	} );
 
-	it( 'should store object update', function( done ) {
-		var id = 'thing',
+	it( 'should fetch object data promise', () => {
+		var object = {title: 'hi'};
+		store.objects = {
+			hello: object
+		};
+
+		return bucket.get( 'hello' ).then( found => {
+			deepEqual( found, object );
+		} );
+	} );
+
+	it( 'should store object update callback', ( done ) => {
+		const id = 'thing',
 			object = {one: 'two'};
 
 		bucket.update( id, object, function() {
 			bucket.get( id, function( err, savedObject ) {
-				assert.deepEqual( object, savedObject );
+				deepEqual( object, savedObject );
 				done();
 			} );
 		} );
 	} );
 
-	it( 'should update with options', function( done ) {
-		var id = 'thing',
+	it( 'should update with options callback', ( done ) => {
+		const id = 'thing',
 			object = {one: 'two'}
 
 		bucket.update( id, object, {}, function() {
 			bucket.get( id, function( err, savedObject ) {
-				assert.deepEqual( object, savedObject );
+				deepEqual( object, savedObject );
 				done();
 			} )
 		} )
 	} );
 
-	it( 'should delete object data', function( done ) {
+	it( 'should delete object data callback', ( done ) => {
 		store.objects = {
 			hello: {title: 'hola mundo'}
 		};
 
 		bucket.remove( 'hello', function() {
-			assert.ok( !store.objects.hello );
+			ok( !store.objects.hello );
 			done();
 		} );
 	} );
 
-	it( 'should fetch object version', () => {
+	it( 'should delete object data promise', () => {
+		store.objects = {
+			hello: {title: 'hola mundo'}
+		};
+
+		return bucket.remove( 'hello' ).then( () => {
+			ok( !store.objects.hello );
+		} );
+	} );
+
+	it( 'should fetch object version callback', ( done ) => {
 		store.objects = {
 			thing: { other: 'thing' }
 		};
 		bucket.getVersion( 'thing', ( error, version ) => {
-			assert.equal( version, 0 );
+			equal( version, 0 );
+			done();
 		} );
 	} );
 
+	it( 'should fetch object version promise', () => {
+		store.objects = {
+			thing: { other: 'thing' }
+		};
+		bucket.getVersion( 'thing' ).then( ( version ) => {
+			equal( version, 0 );
+		} );
+	} );
 } );