Merge pull request #35 from Simperium/add/bucket-errors

Update Channel error handling

Author: beaucollins

src/simperium/channel.js

@@ -152,7 +152,7 @@ internal.applyChange = function( change, ghost ) {
 	//	 clientid: 'node-b9776e96-c068-42ae-893a-03f50833bddb',
 	//	 error: 400 }
 	if ( change.error ) {
-		error = new Error( 'Could not apply change to ' + ghost.key );
+		error = new Error( `${change.error} - Could not apply change to: ${ghost.key}` );
 		error.code = change.error;
 		error.change = change;
 		error.ghost = ghost;
@@ -232,6 +232,9 @@ export default function Channel( appid, access_token, bucket, store ) {
 		bucket.emit( 'index' );
 	} );
 
+	// forward errors to bucket instance
+	this.on( 'error', bucket.emit.bind( bucket, 'error' ) )
+
 	bucket.update = function( id, object, options, callback ) {
 		if ( typeof options === 'function' ) {
 			callback = options;

src/simperium/ghost/store.js

@@ -35,6 +35,7 @@ Store.prototype.get = function( id ) {
 			var ghost = this.index[id];
 			if ( !ghost ) {
 				ghost = {data: {}};
+				ghost.key = id;
 				this.index[id] = JSON.stringify( ghost );
 			} else {
 				ghost = JSON.parse( ghost );

test/simperium/channel_test.js

@@ -2,7 +2,7 @@
 import Channel from '../../src/simperium/channel'
 import util from 'util'
 import { parseMessage } from '../../src/simperium/util'
-import assert from 'assert'
+import assert, { equal } from 'assert'
 import * as fn from './fn'
 import jsondiff from '../../src/simperium/jsondiff'
 import defaultGhostStoreProvider from '../../src/simperium/ghost/default'
@@ -309,6 +309,18 @@ describe( 'Channel', function() {
 			bucket.update( key, {title: 'Goodbye world'} );
 		} );
 
+		it( 'should emit errors on the bucket instance', function( done ) {
+			const error = {error: 404, id: 'thing', ccids: ['abc']}
+			bucket.on( 'error', ( e ) => {
+				process.nextTick( () => {
+					equal( 404, e.code )
+					equal( `${ e.code } - Could not apply change to: ${error.id}`, e.message )
+					done()
+				} )
+			} )
+			channel.handleMessage( 'c:' + JSON.stringify( [ error ] ) );
+		} );
+
 		it( 'should ignore 412 change errors', function( done ) {
 			// if a change is sent and acknowledged with a 412, change should be dequeued and
 			// no error should be emitted