fix: reconcile severity labels on all-clear reruns

Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>

Author: lelia

socket_basics/core/notification/manager.py

@@ -510,6 +510,15 @@ def _alert_group(alert: Dict[str, Any], comp: Dict[str, Any]) -> str:
                     notifier_data = per_notifier_notifications[notification_key]
                     notifier_facts['notifications'] = notifier_data
                     logger.debug('Using pre-formatted data for notifier %s: %s items', notifier_name, len(notifier_data) if isinstance(notifier_data, list) else 1)
+                elif notification_key == 'github_pr':
+                    # GitHub PR label reconciliation still needs to run on "all clear"
+                    # reruns where there are no current notification sections.
+                    notifier_facts['notifications'] = []
+                    logger.debug(
+                        'No pre-formatted data found for notifier %s (key: %s); passing empty notifications for label reconciliation',
+                        notifier_name,
+                        notification_key,
+                    )
                 else:
                     # No pre-formatted data available - skip this notifier to avoid sending wrong format
                     logger.debug('No pre-formatted data found for notifier %s (key: %s), skipping to avoid format mismatch', notifier_name, notification_key)

tests/test_notification_manager_github_pr.py

@@ -0,0 +1,22 @@
+from socket_basics.core.notification.manager import NotificationManager
+
+
+class _DummyGithubPrNotifier:
+    name = "github_pr"
+
+    def __init__(self):
+        self.payloads = []
+
+    def notify(self, facts):
+        self.payloads.append(facts)
+
+
+def test_notify_all_passes_empty_notifications_to_github_pr_for_all_clear():
+    notifier = _DummyGithubPrNotifier()
+    nm = NotificationManager({}, app_config={"repo": "SocketDev/socket-basics"})
+    nm.notifiers = [notifier]
+
+    nm.notify_all({"components": [], "notifications": {}})
+
+    assert len(notifier.payloads) == 1
+    assert notifier.payloads[0]["notifications"] == []