Commit a224af3
committed
fix(build): pass environment to subprocess exec calls on Windows
Windows builds were failing with 'Could not locate Visual Studio installation'
even though VS environment variables (VCINSTALLDIR, WindowsSDKVersion, INCLUDE,
LIB) were successfully set via GITHUB_ENV and present in process.env.
Root cause: The exec() helper from @socketsecurity/lib doesn't automatically
inherit the parent process environment. Subprocesses (configure.py, ninja) were
running without the VS environment variables.
Fix: Explicitly pass 'env: process.env' to exec() calls for:
- configure.py (line 1432)
- ninja build (line 1505)
This ensures VS environment variables are inherited by Python and ninja
subprocesses, allowing them to locate Visual Studio.
Debug logging added in 972b591 removed as issue is now identified and fixed.1 parent 67a6938 commit a224af3
1 file changed
Lines changed: 2 additions & 26 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1428 | 1428 | | |
1429 | 1429 | | |
1430 | 1430 | | |
1431 | | - | |
1432 | | - | |
1433 | | - | |
1434 | | - | |
1435 | | - | |
1436 | | - | |
1437 | | - | |
1438 | | - | |
1439 | | - | |
1440 | | - | |
1441 | | - | |
1442 | | - | |
1443 | | - | |
1444 | | - | |
1445 | | - | |
1446 | | - | |
1447 | | - | |
1448 | | - | |
1449 | | - | |
1450 | | - | |
1451 | | - | |
1452 | | - | |
1453 | | - | |
1454 | | - | |
1455 | 1431 | | |
1456 | | - | |
| 1432 | + | |
1457 | 1433 | | |
1458 | 1434 | | |
1459 | 1435 | | |
| |||
1502 | 1478 | | |
1503 | 1479 | | |
1504 | 1480 | | |
1505 | | - | |
| 1481 | + | |
1506 | 1482 | | |
1507 | 1483 | | |
1508 | 1484 | | |
| |||
0 commit comments