Stop passing --lazy-mode to the coana CLI (#336)

The coana CLI no longer accepts --lazy-mode, so a reachability run started with
--reach-lazy-mode failed on an unrecognized argument.

--reach-lazy-mode is kept as a hidden no-op, matching how
--reach-disable-analysis-splitting was deprecated, so pipelines that still pass
it keep working rather than failing argument parsing. Nothing is forwarded to
coana, and the flag is dropped from the reachability documentation.

No version bump: this is not being released on its own.

Author: BarrensZeppelin

docs/cli-reference.md

@@ -156,7 +156,7 @@ socketcli [-h] [--api-token API_TOKEN] [--repo REPO] [--workspace WORKSPACE] [--
           [--reach] [--reach-version REACH_VERSION] [--reach-analysis-timeout REACH_ANALYSIS_TIMEOUT]
           [--reach-analysis-memory-limit REACH_ANALYSIS_MEMORY_LIMIT] [--reach-concurrency REACH_CONCURRENCY] [--reach-ecosystems REACH_ECOSYSTEMS]
           [--reach-min-severity <level>] [--reach-skip-cache] [--reach-disable-analytics] [--reach-enable-analysis-splitting] [--reach-detailed-analysis-log-file]
-          [--reach-lazy-mode] [--reach-use-only-pregenerated-sboms] [--reach-debug] [--reach-disable-external-tool-checks]
+          [--reach-use-only-pregenerated-sboms] [--reach-debug] [--reach-disable-external-tool-checks]
           [--reach-output-file REACH_OUTPUT_FILE] [--only-facts-file] [--version]
 ````
 
@@ -286,7 +286,6 @@ If you don't want to provide the Socket API Token every time then you can use th
 | `--reach-disable-analytics`        | False    | False   | Disable analytics collection during reachability analysis                                                                  |
 | `--reach-enable-analysis-splitting` | False   | False   | Enable analysis splitting/bucketing (a legacy performance feature). Splitting is disabled by default.                      |
 | `--reach-detailed-analysis-log-file` | False  | False   | Write a detailed analysis log file; its path is printed to stdout                                                          |
-| `--reach-lazy-mode`                | False    | False   | Enable lazy mode (experimental performance feature)                                                                        |
 | `--reach-use-only-pregenerated-sboms` | False | False   | Build the scan only from pre-generated CycloneDX (CDX) and SPDX files in your project (requires --reach)                    |
 | `--reach-debug`                    | False    | False   | Enable coana debug output (`--debug`) for the analysis, independent of the global `--enable-debug`                         |
 | `--reach-disable-external-tool-checks` | False | False | Disable coana's external tool availability checks (passes `--disable-external-tool-checks`)                              |

socketsecurity/config.py

@@ -176,7 +176,7 @@ class CliConfig:
     reach_disable_analysis_splitting: bool = False  # Deprecated, kept for backwards compatibility
     reach_enable_analysis_splitting: bool = False
     reach_detailed_analysis_log_file: bool = False
-    reach_lazy_mode: bool = False
+    reach_lazy_mode: bool = False  # Deprecated, kept for backwards compatibility
     reach_ecosystems: Optional[List[str]] = None
     reach_exclude_paths: Optional[List[str]] = None
     reach_skip_cache: bool = False
@@ -1091,7 +1091,7 @@ def create_argument_parser() -> argparse.ArgumentParser:
         "--reach-lazy-mode",
         dest="reach_lazy_mode",
         action="store_true",
-        help="Enable lazy mode for reachability analysis. This is an experimental feature for improving performance"
+        help=argparse.SUPPRESS  # Deprecated, kept for backwards compatibility (no-op)
     )
     reachability_group.add_argument(
         "--reach-output-file",

socketsecurity/core/tools/reachability.py

@@ -88,7 +88,6 @@ def run_reachability_analysis(
         disable_analytics: bool = False,
         enable_analysis_splitting: bool = False,
         detailed_analysis_log_file: bool = False,
-        lazy_mode: bool = False,
         repo_name: Optional[str] = None,
         branch_name: Optional[str] = None,
         version: Optional[str] = None,
@@ -123,7 +122,6 @@ def run_reachability_analysis(
             disable_analytics: Disable analytics sharing
             enable_analysis_splitting: Enable analysis splitting (disabled by default)
             detailed_analysis_log_file: Print detailed analysis log file path
-            lazy_mode: Enable lazy mode for analysis
             repo_name: Repository name
             branch_name: Branch name
             version: @coana-tech/cli version to use. None uses the pinned
@@ -172,9 +170,6 @@ def run_reachability_analysis(
         if detailed_analysis_log_file:
             coana_args.append("--print-analysis-log-file")
 
-        if lazy_mode:
-            coana_args.append("--lazy-mode")
-        
         # KEY POINT: Only add manifest tar hash if we have one
         if tar_hash:
             coana_args.extend(["--run-without-docker", "--manifests-tar-hash", tar_hash])

socketsecurity/socketcli.py

@@ -450,7 +450,6 @@ def main_code():
                         disable_analytics=config.reach_disable_analytics or False,
                         enable_analysis_splitting=config.reach_enable_analysis_splitting or False,
                         detailed_analysis_log_file=config.reach_detailed_analysis_log_file or False,
-                        lazy_mode=config.reach_lazy_mode or False,
                         repo_name=None if repo_defaulted else config.repo,
                         branch_name=None if branch_defaulted else config.branch,
                         version=config.reach_version,