fix(ci): restrict SCM diffs to pull requests

Author: lelia

socketsecurity/socketcli.py

@@ -133,12 +133,8 @@ def _select_pull_request_provider(integration_type: str, scm_type: str) -> str:
     return scm_type if scm_type in ("github", "gitlab") else integration_type
 
 
-def _should_create_scm_diff(
-    event_type: str,
-    enable_diff: bool = False,
-    force_diff_mode: bool = False,
-) -> bool:
-    return event_type == "diff" or enable_diff or force_diff_mode
+def _should_create_scm_diff(event_type: str) -> bool:
+    return event_type == "diff"
 
 
 def build_socket_sdk(config: CliConfig) -> socketdev:
@@ -745,11 +741,7 @@ def _is_unprocessed(c):
 
         elif scm is not None and not force_api_mode:
             log.info("Push initiated flow")
-            if _should_create_scm_diff(
-                scm_event_type,
-                enable_diff=config.enable_diff,
-                force_diff_mode=force_diff_mode,
-            ):
+            if _should_create_scm_diff(scm_event_type):
                 log.info("Starting comment logic for PR/MR event")
                 diff = core.create_new_diff(
                     scan_paths,

tests/unit/test_socketcli.py

@@ -78,16 +78,10 @@ def test_scm_merge_request_event_creates_diff():
     assert socketcli._should_create_scm_diff("diff") is True
 
 
-def test_scm_branch_event_defaults_to_full_scan():
+def test_scm_branch_event_always_uses_full_scan():
     assert socketcli._should_create_scm_diff("main") is False
 
 
-@pytest.mark.parametrize("override", ["enable_diff", "force_diff_mode"])
-def test_scm_branch_event_honors_diff_override(override):
-    options = {override: True}
-    assert socketcli._should_create_scm_diff("main", **options) is True
-
-
 # ---------------------------------------------------------------------------
 # Buildkite-aware infrastructure error formatting.
 # ---------------------------------------------------------------------------