Elementwise setPositions fix

Author: kirillgarbar

src/GraphBLAS-sharp.Backend/Matrix/COOMatrix/COOMatrix.fs

@@ -11,16 +11,15 @@ module COOMatrix =
     let private setPositions<'a when 'a: struct> (clContext: ClContext) workGroupSize =
 
         let setPositions =
-            <@ fun (ndRange: Range1D) prefixSumArrayLength (allRowsBuffer: ClArray<int>) (allColumnsBuffer: ClArray<int>) (allValuesBuffer: ClArray<'a>) (prefixSumArrayBuffer: ClArray<int>) (resultRowsBuffer: ClArray<int>) (resultColumnsBuffer: ClArray<int>) (resultValuesBuffer: ClArray<'a>) ->
+            <@ fun (ndRange: Range1D) prefixSumArrayLength resultLength (allRowsBuffer: ClArray<int>) (allColumnsBuffer: ClArray<int>) (allValuesBuffer: ClArray<'a>) (prefixSumArrayBuffer: ClArray<int>) (resultRowsBuffer: ClArray<int>) (resultColumnsBuffer: ClArray<int>) (resultValuesBuffer: ClArray<'a>) ->
 
                 let i = ndRange.GlobalID0
+                let index = prefixSumArrayBuffer.[i]
 
-                if i = prefixSumArrayLength - 1
-                   || i < prefixSumArrayLength
-                      && prefixSumArrayBuffer.[i]
-                         <> prefixSumArrayBuffer.[i + 1] then
-                    let index = prefixSumArrayBuffer.[i]
-
+                if (i < prefixSumArrayLength - 1
+                    && index <> prefixSumArrayBuffer.[i + 1])
+                   || (i = prefixSumArrayLength - 1
+                       && index < resultLength) then
                     resultRowsBuffer.[index] <- allRowsBuffer.[i]
                     resultColumnsBuffer.[index] <- allColumnsBuffer.[i]
                     resultValuesBuffer.[index] <- allValuesBuffer.[i] @>
@@ -82,6 +81,7 @@ module COOMatrix =
                         kernel.KernelFunc
                             ndRange
                             prefixSumArrayLength
+                            resultLength
                             allRows
                             allColumns
                             allValues

tests/GraphBLAS-sharp.Tests/Helpers.fs

@@ -440,7 +440,7 @@ module Utils =
         |> Array.map (fun caseInfo -> FSharpValue.MakeUnion(caseInfo, [||]) :?> 'a)
         |> List.ofArray
 
-    let avaliableContexts (platformRegex: string) =
+    let availableContexts (platformRegex: string) =
         let mutable e = ErrorCode.Unknown
 
         Cl.GetPlatformIDs &e
@@ -520,7 +520,7 @@ module Utils =
           MatrixCase: MatrixFormat }
 
     let testCases =
-        [ avaliableContexts "" |> Seq.map box
+        [ availableContexts "" |> Seq.map box
           listOfUnionCases<MatrixFormat> |> Seq.map box ]
         |> List.map List.ofSeq
         |> cartesian