refactor: list instead array in LIL

Author: IgorErin

src/GraphBLAS-sharp.Backend/Matrix/CSR/Matrix.fs

@@ -149,14 +149,15 @@ module Matrix =
         fun (processor: MailboxProcessor<_>) allocationMode (matrix: ClMatrix.CSR<'a>) ->
             runLazy processor allocationMode matrix
             |> Seq.map (fun lazyValue -> lazyValue.Value)
-            |> Seq.toArray
 
     let toLIL (clContext: ClContext) workGroupSize =
 
         let byRows = byRows clContext workGroupSize
 
         fun (processor: MailboxProcessor<_>) allocationMode (matrix: ClMatrix.CSR<'a>) ->
-            let rows = byRows processor allocationMode matrix
+            let rows =
+                byRows processor allocationMode matrix
+                |> Seq.toList
 
             { Context = clContext
               RowCount = matrix.RowCount

src/GraphBLAS-sharp.Backend/Matrix/LIL/Matrix.fs

@@ -16,19 +16,20 @@ module Matrix =
 
             let rowsPointers =
                 matrix.Rows
-                |> Array.map
+                |> List.map
                     (function
                     | None -> 0
                     | Some vector -> vector.Values.Length)
+                |> List.toArray
                 // prefix sum
                 |> Array.scan (+) 0
                 |> fun pointers -> clContext.CreateClArrayWithSpecificAllocationMode(allocationMode, pointers)
 
             let valuesByRows, columnsIndicesByRows =
                 matrix.Rows
-                |> Array.choose id
-                |> Array.map (fun vector -> vector.Values, vector.Indices)
-                |> Array.unzip
+                |> List.choose id
+                |> List.map (fun vector -> vector.Values, vector.Indices)
+                |> List.unzip
 
             let values =
                 concatValues processor allocationMode valuesByRows

src/GraphBLAS-sharp.Backend/Matrix/Matrix.fs

@@ -46,10 +46,7 @@ module Matrix =
                       Values = copyData processor allocationMode m.Values }
             | ClMatrix.LIL matrix ->
                 matrix.Rows
-                |> Array.map (
-                    Option.bind
-                    <| (Some << (vectorCopy processor allocationMode))
-                )
+                |> List.map (Option.map (vectorCopy processor allocationMode))
                 |> fun rows ->
                     { Context = clContext
                       RowCount = matrix.RowCount

src/GraphBLAS-sharp.Backend/Matrix/SpGeMM/Expand.fs

@@ -310,7 +310,7 @@ module Expand =
 
                             result)
                         lazyRow.Value)
-            |> Seq.toArray
+            |> Seq.toList
             |> fun rows ->
                 rightMatrixRowsLengths.Free processor
 

src/GraphBLAS-sharp.Backend/Objects/Matrix.fs

@@ -86,7 +86,7 @@ module ClMatrix =
         { Context: ClContext
           RowCount: int
           ColumnCount: int
-          Rows: ClVector.Sparse<'elem> option []
+          Rows: ClVector.Sparse<'elem> option list
           NNZ: int }
 
         interface IDeviceMemObject with

src/GraphBLAS-sharp/Objects/Matrix.fs

@@ -155,7 +155,7 @@ module Matrix =
     type LIL<'a when 'a: struct> =
         { RowCount: int
           ColumnCount: int
-          Rows: Vector.Sparse<'a> option []
+          Rows: Vector.Sparse<'a> option list
           NNZ: int }
 
         static member FromArray2D(array: 'a [,], isZero: 'a -> bool) =
@@ -172,7 +172,6 @@ module Matrix =
                           Some vector
                       else
                           None ]
-                |> Array.ofList
 
             { RowCount = Array2D.length1 array
               ColumnCount = Array2D.length2 array
@@ -183,7 +182,7 @@ module Matrix =
 
             let rows =
                 this.Rows
-                |> Array.map (Option.bind (fun vector -> Some <| vector.ToDevice(context)))
+                |> List.map (Option.map (fun vector -> vector.ToDevice(context)))
 
             { Context = context
               RowCount = this.RowCount

src/GraphBLAS-sharp/Objects/MatrixExtensions.fs

@@ -36,7 +36,7 @@ module MatrixExtensions =
                   ColumnCount = m.ColumnCount
                   Rows =
                       m.Rows
-                      |> Array.map (Option.bind (fun row -> Some <| row.ToHost q))
+                      |> List.map (Option.map (fun row -> row.ToHost q))
                   NNZ = m.NNZ }
                 |> Matrix.LIL
 

tests/GraphBLAS-sharp.Tests/Helpers.fs

@@ -137,7 +137,7 @@ module Utils =
         "Rows count must be the same"
         |> Expect.equal actual.RowCount expected.RowCount
 
-        Array.iter2
+        List.iter2
             (fun actualRow expected ->
                 match actualRow, expected with
                 | Some actualVector, Some expectedVector -> compareSparseVectors isEqual actualVector expectedVector