Fix sync for MatrixTuples

Author: dpanfilyonok

src/GraphBLAS-sharp/Backend/CSRMatrix/Mxv.fs

@@ -7,6 +7,7 @@ open GraphBLAS.FSharp.Backend.Common
 open Brahma.OpenCL
 
 module internal Mxv =
+    // not finished
     let pcsr (matrix: CSRMatrix<'a>) (vector: BitmapVector<'a>) mask (semiring: ISemiring<'a>) = opencl {
         let (ClosedBinaryOp plus) = semiring.Plus
         let (ClosedBinaryOp times) = semiring.Times

src/GraphBLAS-sharp/Backend/Common/RemoveDuplicates.fs

@@ -7,7 +7,7 @@ module internal RemoveDuplicates =
     let run (array: 'a[]) = opencl {
         let inputLength = array.Length
 
-        let isUniqueBitmap =
+        let getUniqueBitmap =
             <@
                 fun (ndRange: _1D)
                     (inputArray: 'a[])
@@ -32,9 +32,9 @@ module internal RemoveDuplicates =
             @>
 
         let bitmap = Array.create inputLength 1
-        do! RunCommand isUniqueBitmap <| fun kernelPrepare ->
-            let ndRange = _1D(Utils.workSize inputLength, Utils.workGroupSize)
-            kernelPrepare ndRange array bitmap
+        do! RunCommand getUniqueBitmap <| fun kernelPrepare ->
+            let range = _1D(Utils.workSize inputLength, Utils.workGroupSize)
+            kernelPrepare range array bitmap
 
         let resultLength = Array.zeroCreate 1
         do! PrefixSum.runInplace bitmap resultLength
@@ -43,8 +43,8 @@ module internal RemoveDuplicates =
 
         let outputArray = Array.zeroCreate resultLength
         do! RunCommand setPositions <| fun kernelPrepare ->
-            let ndRange = _1D(Utils.workSize inputLength, Utils.workGroupSize)
-            kernelPrepare ndRange array bitmap outputArray
+            let range = _1D(Utils.workSize inputLength, Utils.workGroupSize)
+            kernelPrepare range array bitmap outputArray
 
         return outputArray
     }

src/GraphBLAS-sharp/Methods/Matrix.fs

@@ -48,7 +48,7 @@ module Matrix =
     let tuples (matrix: Matrix<'a>) : GraphblasEvaluation<MatrixTuples<'a>> =
         let matrixTuples =
             match matrix with
-            | MatrixCOO coo -> COOMatrix.GetTuples.from coo
+            | MatrixCOO matrix -> COOMatrix.GetTuples.from matrix
             | _ -> failwith "Not Implemented"
 
         graphblas { return! EvalGB.fromCl matrixTuples }
@@ -200,9 +200,10 @@ module Matrix =
 module MatrixTuples =
     let synchronize (matrixTuples: MatrixTuples<'a>) =
         opencl {
-            let! _ = ToHost matrixTuples.RowIndices
-            let! _ = ToHost matrixTuples.ColumnIndices
-            let! _ = ToHost matrixTuples.Values
+            let! rows = if matrixTuples.RowIndices.Length = 0 then opencl { return [||] } else ToHost matrixTuples.RowIndices
+            let! cols = if matrixTuples.ColumnIndices.Length = 0 then opencl { return [||] } else ToHost matrixTuples.ColumnIndices
+            let! vals = if matrixTuples.Values.Length = 0 then opencl { return [||] } else ToHost matrixTuples.Values
+
             return ()
         }
         |> EvalGB.fromCl

src/GraphBLAS-sharp/Objects/Matrix.fs

@@ -30,6 +30,15 @@ and COOMatrix<'a> =
         Values: 'a[]
     }
 
+    override this.ToString() =
+        [
+            sprintf "COO Matrix     %ix%i \n" this.RowCount this.ColumnCount
+            sprintf "RowIndices:    %A \n" this.Rows
+            sprintf "ColumnIndices: %A \n" this.Columns
+            sprintf "Values:        %A \n" this.Values
+        ]
+        |> String.concat ""
+
     static member FromTuples(rowCount: int, columnCount: int, rows: int[], columns: int[], values: 'a[]) =
         {
             RowCount = rowCount
@@ -44,7 +53,7 @@ and COOMatrix<'a> =
             array
             |> Seq.cast<'a>
             |> Seq.mapi (fun idx v -> (idx / Array2D.length2 array, idx % Array2D.length2 array, v))
-            |> Seq.filter (fun (i, j, v) -> not <| isZero v)
+            |> Seq.filter (fun (_, _, v) -> not <| isZero v)
             |> Array.ofSeq
             |> Array.unzip3
 

src/GraphBLAS-sharp/Objects/Vector.fs

@@ -15,6 +15,15 @@ and COOVector<'a> =
         Values: 'a[]
     }
 
+    override this.ToString() =
+        [
+            sprintf "Sparse Vector\n"
+            sprintf "Size:    %i \n" this.Size
+            sprintf "Indices: %A \n" this.Indices
+            sprintf "Values:  %A \n" this.Values
+        ]
+        |> String.concat ""
+
 and BitmapVector<'a> =
     {
         Bitmap: bool[]